Bug 2124361 - Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra functionality and without weak references
Summary: Review Request: rust-servo_arc - Fork of std::sync::Arc with some extra funct...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2124365
TreeView+ depends on / blocked
 
Reported: 2022-09-05 20:01 UTC by Kalev Lember
Modified: 2022-10-13 18:59 UTC (History)
2 users (show)

Fixed In Version: rust-servo_arc-0.1.1-2.fc38 rust-servo_arc-0.1.1-2.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-13 18:44:59 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-09-05 20:01:22 UTC
Spec URL: https://kalev.fedorapeople.org/rust-servo_arc.spec
SRPM URL: https://kalev.fedorapeople.org/rust-servo_arc-0.1.1-1.fc38.src.rpm

Description:
Fork of std::sync::Arc with some extra functionality and without weak
references.

Fedora Account System Username: kalev

rust-servo_arc is a dependency for librsvg2 (I'm trying to get it to build using system rust creates instead of vendored).

Comment 1 Fabio Valentini 2022-09-05 20:50:07 UTC
> # license file is missing from the crate

In the case of MIT and Apache-2.0 licenses, this is actually a problem.
Both require redistributed sources to ship a copy of the license text.

There are no license files in the upstream repo for this crate, either:
https://github.com/servo/servo/tree/master/components/servo_arc

But some crates in the /components/ directory seem to have LICENSE-MIT and LICENSE-Apache files, so filing an issue with the project should hopefully get this resolved.

Comment 2 Kalev Lember 2022-09-06 08:12:56 UTC
Done: https://github.com/servo/servo/issues/28966

Comment 3 Kalev Lember 2022-10-01 09:31:20 UTC
* Sat Oct 01 2022 Kalev Lember <klember> 0.1.1-2
- Backport upstream patch to add license files (rhbz#2124361)

Spec URL: https://kalev.fedorapeople.org/rust-servo_arc.spec
SRPM URL: https://kalev.fedorapeople.org/rust-servo_arc-0.1.1-2.fc38.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=92464208

Comment 4 Fabio Valentini 2022-10-11 17:45:39 UTC
Sorry for the delay. Package looks good to me now, thanks for filing the upstream issue.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 5 Kalev Lember 2022-10-12 10:14:57 UTC
Thanks, Fabio!

Comment 6 Gwyn Ciesla 2022-10-12 14:05:34 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-servo_arc

Comment 7 Fedora Update System 2022-10-13 18:43:40 UTC
FEDORA-2022-acfeadddbd has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-acfeadddbd

Comment 8 Fedora Update System 2022-10-13 18:44:59 UTC
FEDORA-2022-acfeadddbd has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Kalev Lember 2022-10-13 18:59:08 UTC
Package imported and built.


Note You need to log in before you can comment on or make changes to this bug.