Bug 2126894

Summary:	ansible-collection-microsoft-sql does not BuildRequire ansible-packaging
Product:	[Fedora] Fedora	Reporter:	Maxwell G <maxwell>
Component:	ansible-collection-microsoft-sql	Assignee:	Sergei Petrosian <spetrosi>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	38	CC:	nhosoi, rmeggins, spetrosi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-29 17:55:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2126557

Description Maxwell G 2022-09-14 16:50:10 UTC

We have determined that this package uses the Ansible Collection macros from ansible-packaging but does not directly BuildRequire it. These macros used to be part of ansible 2.9 and ansible-core before they were split out. In order to ease this transition, we implemented a compatibility layer to pull in ansible-packaging along with ansible 2.9 or ansible-core. We will be removing this compatibility layer in the coming weeks; packages must be amended to directly depend on ansible-packaging.

Please replace any build requirement on ansible or ansible-core with a single `BuildRequires: ansible-packaging` line. This change should be made in distgit as soon as possible; rebuilding the package after making this change is not necessary. Please close this bug after the necessary change has been pushed to all active distgit branches.

Thank you for your cooperation!

Comment 1 Maxwell G 2022-09-14 17:36:53 UTC

The %ansible_collection_build_install macro defined in this package is also problematic. Building should occur in %build and installation should occur in %install. Please use %ansible_collection_build and %ansible_collection_install in the appropriate places.

Comment 2 Maxwell G 2022-09-14 17:39:35 UTC

(In reply to Maxwell G from comment #1)
> The %ansible_collection_build_install macro defined in this package is also
> problematic. Building should occur in %build and installation should occur
> in %install. Please use %ansible_collection_build and
> %ansible_collection_install in the appropriate places.

I meant to leave this comment in https://bugzilla.redhat.com/show_bug.cgi?id=2126901. I'm sorry about that.

Comment 3 Ben Cotton 2023-02-07 14:55:04 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 4 Sergei Petrosian 2023-05-29 17:55:13 UTC

This has been fixed, see https://src.fedoraproject.org/rpms/ansible-collection-microsoft-sql/blob/rawhide/f/ansible-collection-microsoft-sql.spec#_7

Thank you