Bug 2126901 - ansible-collection-microsoft-sql Packaging Guidelines violation: legibility
Summary: ansible-collection-microsoft-sql Packaging Guidelines violation: legibility
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ansible-collection-microsoft-sql
Version: 38
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergei Petrosian
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2126900 2129108
TreeView+ depends on / blocked
 
Reported: 2022-09-14 17:32 UTC by Maxwell G
Modified: 2023-05-30 10:14 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
: 2129099 2129106 2129108 (view as bug list)
Environment:
Last Closed: 2023-05-30 10:14:40 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Fedora Package Sources ansible-collection-microsoft-sql pull-request 20# 0 None None None 2022-09-20 13:07:34 UTC
Fedora Package Sources ansible-collection-microsoft-sql pull-request 21# 0 None None None 2022-09-22 13:06:23 UTC

Description Maxwell G 2022-09-14 17:32:12 UTC
I already fixed most of Fedora's ansible collection packages to BuildRequire ansible-packaging (see https://bugzilla.redhat.com/2126894), but I was unable to fix this package given the complexity and illegibility of its specfile.

Please consider removing the RHEL conditionals from this package's Fedora specfile or otherwise making it more legible. For the EPEL packages I maintain, I also prefer to use the same specfile for both Fedora and EPEL, but I avoid doing so when it would require too many conditionals or other complexity. 

From the Packaging Guidelines:

> All spec files MUST be legible and maintained in such a way that the community of packagers is able to understand and work with them.

-- https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility

You can look at https://src.fedoraproject.org/rpms/ansible-collection-community-rabbitmq for an example of a collection package. I am working on[1] writing official packaging guidelines for Ansible collections, as well.

[1]: https://pagure.io/packaging-committee/pull-request/1201

Comment 1 Maxwell G 2022-09-14 17:39:58 UTC
The %ansible_collection_build_install macro defined in this package is also problematic. Building should occur in %build and installation should occur in %install. Please use %ansible_collection_build and %ansible_collection_install in the appropriate places.

Comment 2 Ben Cotton 2023-02-07 15:10:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 3 Sergei Petrosian 2023-05-30 10:14:40 UTC
Hi Maxwell,

I recently noticed that this ticket remained open, I cleaned the code but forgot about the ticket.
I did all the simplifications to the spec file that you requested, and recently did some more to store more RHEL related code in a separate sources like linux-system-roles spec.
So I'll resolve this ticket, feel free to re-open if you have any further concerns.

Thank you


Note You need to log in before you can comment on or make changes to this bug.