Bug 2126901

Summary: ansible-collection-microsoft-sql Packaging Guidelines violation: legibility
Product: [Fedora] Fedora Reporter: Maxwell G <maxwell>
Component: ansible-collection-microsoft-sqlAssignee: Sergei Petrosian <spetrosi>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 38CC: nhosoi, rmeggins, spetrosi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2129099 2129106 2129108 (view as bug list) Environment:
Last Closed: 2023-05-30 10:14:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2126900, 2129108    

Description Maxwell G 2022-09-14 17:32:12 UTC 
I already fixed most of Fedora's ansible collection packages to BuildRequire ansible-packaging (see https://bugzilla.redhat.com/2126894), but I was unable to fix this package given the complexity and illegibility of its specfile.

Please consider removing the RHEL conditionals from this package's Fedora specfile or otherwise making it more legible. For the EPEL packages I maintain, I also prefer to use the same specfile for both Fedora and EPEL, but I avoid doing so when it would require too many conditionals or other complexity. 

From the Packaging Guidelines:

> All spec files MUST be legible and maintained in such a way that the community of packagers is able to understand and work with them.

-- https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility

You can look at https://src.fedoraproject.org/rpms/ansible-collection-community-rabbitmq for an example of a collection package. I am working on[1] writing official packaging guidelines for Ansible collections, as well.

[1]: https://pagure.io/packaging-committee/pull-request/1201
Comment 1 Maxwell G 2022-09-14 17:39:58 UTC 
The %ansible_collection_build_install macro defined in this package is also problematic. Building should occur in %build and installation should occur in %install. Please use %ansible_collection_build and %ansible_collection_install in the appropriate places.
Comment 2 Ben Cotton 2023-02-07 15:10:30 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 3 Sergei Petrosian 2023-05-30 10:14:40 UTC 
Hi Maxwell,

I recently noticed that this ticket remained open, I cleaned the code but forgot about the ticket.
I did all the simplifications to the spec file that you requested, and recently did some more to store more RHEL related code in a separate sources like linux-system-roles spec.
So I'll resolve this ticket, feel free to re-open if you have any further concerns.

Thank you