Bug 2128486
Summary: | Review Request: python-simple-rlp - Simple RLP (Recursive Length Prefix) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonny Heggheim <hegjon> |
Component: | Package Review | Assignee: | Timothy Redaelli <tredaelli> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, tredaelli |
Target Milestone: | --- | Flags: | tredaelli:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-12-05 22:32:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jonny Heggheim
2022-09-20 18:15:14 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=92232681 Hi, can you please fix the 2 reported problems: python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-simple-rlp/README.md For this one you can use: sed -i 's/\r$//' python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp. For this one, just split the description line, since it's too long Thank you (In reply to Timothy Redaelli from comment #2) > Hi, > > can you please fix the 2 reported problems: > > python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python3-simple-rlp/README.md > > For this one you can use: sed -i 's/\r$//' > > > python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5 > dependencies. This alternative is write in pure python and don't have any > dependencies. Recommended use for projects that don't need the Ethereum > tools. If you already uses the Ethereum tools uses the pyrlp. > > For this one, just split the description line, since it's too long > > Thank you Thanks, I added the sed command in %prep and splited the %description line into shorter lines. Updated srpm and spec file (same URLs) Would you have time to have a look at your requested changes? LGTM Thanks for the review! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-simple-rlp FEDORA-2022-3a55448bc0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0 FEDORA-2022-c99a6df9b1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1 FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3a55448bc0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c99a6df9b1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. Updated for Fedora 36 and later FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. |