Bug 2128486 - Review Request: python-simple-rlp - Simple RLP (Recursive Length Prefix)
Summary: Review Request: python-simple-rlp - Simple RLP (Recursive Length Prefix)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Timothy Redaelli
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-09-20 18:15 UTC by Jonny Heggheim
Modified: 2022-12-10 01:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-05 22:32:38 UTC
Type: ---
Embargoed:
tredaelli: fedora-review+


Attachments (Terms of Use)

Description Jonny Heggheim 2022-09-20 18:15:14 UTC
Spec URL: https://jonny.fedorapeople.org/python-simple-rlp.spec
SRPM URL: https://jonny.fedorapeople.org/python-simple-rlp-0.1.3-1.fc36.src.rpm

Description:
Encode the and decode data structures simple and fast
This module is a alternative to official Ethereum pyrlp.

The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp.

Features:
 * Very simple usage to encode and decode lists of data
 * Very fast to encode
 * Auto serialize python objects (check supported types)
 * Templates to convert bytes in decoded objects
 * No dependencies

Fedora Account System Username: jonny

Comment 1 Jonny Heggheim 2022-09-20 18:15:17 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=92232681

Comment 2 Timothy Redaelli 2022-11-18 16:05:43 UTC
Hi,

can you please fix the 2 reported problems:

python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python3-simple-rlp/README.md

For this one you can use: sed -i 's/\r$//'


python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5 dependencies. This alternative is write in pure python and don't have any dependencies. Recommended use for projects that don't need the Ethereum tools. If you already uses the Ethereum tools uses the pyrlp.

For this one, just split the description line, since it's too long

Thank you

Comment 3 Jonny Heggheim 2022-11-18 16:43:02 UTC
(In reply to Timothy Redaelli from comment #2)
> Hi,
> 
> can you please fix the 2 reported problems:
> 
> python3-simple-rlp.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/python3-simple-rlp/README.md
> 
> For this one you can use: sed -i 's/\r$//'
> 
> 
> python3-simple-rlp.noarch: E: description-line-too-long The pyrlp needs 5
> dependencies. This alternative is write in pure python and don't have any
> dependencies. Recommended use for projects that don't need the Ethereum
> tools. If you already uses the Ethereum tools uses the pyrlp.
> 
> For this one, just split the description line, since it's too long
> 
> Thank you

Thanks, I added the sed command in %prep and splited the %description line into shorter lines.

Updated srpm and spec file (same URLs)

Comment 4 Jonny Heggheim 2022-11-22 17:17:08 UTC
Would you have time to have a look at your requested changes?

Comment 5 Timothy Redaelli 2022-11-30 10:53:34 UTC
LGTM

Comment 6 Jonny Heggheim 2022-11-30 11:31:42 UTC
Thanks for the review!

Comment 7 Gwyn Ciesla 2022-11-30 14:39:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-simple-rlp

Comment 8 Fedora Update System 2022-12-01 10:29:36 UTC
FEDORA-2022-3a55448bc0 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0

Comment 9 Fedora Update System 2022-12-01 10:30:20 UTC
FEDORA-2022-c99a6df9b1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1

Comment 10 Fedora Update System 2022-12-02 02:26:09 UTC
FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3a55448bc0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3a55448bc0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-12-02 02:28:45 UTC
FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-c99a6df9b1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c99a6df9b1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Jonny Heggheim 2022-12-05 22:32:38 UTC
Updated for Fedora 36 and later

Comment 13 Fedora Update System 2022-12-10 01:23:49 UTC
FEDORA-2022-c99a6df9b1 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2022-12-10 01:28:09 UTC
FEDORA-2022-3a55448bc0 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.