Bug 2129106

Summary:	ansible-collection-microsoft-sql Packaging Guidelines violation: legibility
Product:	Red Hat Enterprise Linux 8	Reporter:	Sergei Petrosian <spetrosi>
Component:	ansible-collection-microsoft-sql	Assignee:	Sergei Petrosian <spetrosi>
Status:	CLOSED ERRATA	QA Contact:	Daniel Yeisley <dyeisley>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	8.8	CC:	dyeisley, maxwell, pkettman, rmeggins, spetrosi
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ansible-collection-microsoft-sql-1.3.0-2.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2126901
Clones:	2151281 (view as bug list)		Environment:
Last Closed:	2023-05-16 08:41:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2129108
Bug Blocks:	2151281

Description Sergei Petrosian 2022-09-22 14:23:35 UTC

+++ This bug was initially created as a clone of Bug #2126901 +++

I already fixed most of Fedora's ansible collection packages to BuildRequire ansible-packaging (see https://bugzilla.redhat.com/2126894), but I was unable to fix this package given the complexity and illegibility of its specfile.

Please consider removing the RHEL conditionals from this package's Fedora specfile or otherwise making it more legible. For the EPEL packages I maintain, I also prefer to use the same specfile for both Fedora and EPEL, but I avoid doing so when it would require too many conditionals or other complexity. 

From the Packaging Guidelines:

> All spec files MUST be legible and maintained in such a way that the community of packagers is able to understand and work with them.

-- https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_legibility

You can look at https://src.fedoraproject.org/rpms/ansible-collection-community-rabbitmq for an example of a collection package. I am working on[1] writing official packaging guidelines for Ansible collections, as well.

[1]: https://pagure.io/packaging-committee/pull-request/1201

--- Additional comment from Maxwell G on 2022-09-14 19:39:58 CEST ---

The %ansible_collection_build_install macro defined in this package is also problematic. Building should occur in %build and installation should occur in %install. Please use %ansible_collection_build and %ansible_collection_install in the appropriate places.

Comment 13 errata-xmlrpc 2023-05-16 08:41:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (ansible-collection-microsoft-sql bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:2895