Bug 212923 (pear-XML-RSS)
Summary: | Review Request: php-pear-XML-RSS - RSS parser | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Remi Collet <fedora> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | Flags: | wtogami:
fedora-cvs+
|
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-11 02:29:16 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 212925 |
Description
Christopher Stone
2006-10-30 04:50:36 UTC
REVIEW: * Source XML_RSS-0.9.10.tgz is the same as upstream * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible (PHP License). * latest version is being packaged. * BuildRequires are proper. * %clean is present. * Builds fine in mock (development). * package installs properly * rpmlint W: php-pear-XML-RSS no-documentation * final provides are sane: php-pear(XML_RSS) = 0.9.10 php-pear-XML-RSS = 0.9.10-1.fc7 * %check is not present; * owns the directories it creates (XML own by php-pear) * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear install) * code, not content. * no documentation SHOULD : - requires other extensions with minimal version (php-pear(XML_Parser) >= 1.0.1) - Add the PHP license in the %doc Test provided upstream succeed (using php-PHPUnit): $ php XML_RSS_Infrastructure_Test.php TestCase XML_RSS_Infrastructure_Test->testIsXML_Parser() passed TestCase XML_RSS_Infrastructure_Test->testBug2310() passed $ php XML_RSS_Parsing_Test.php TestCase XML_RSS_Parsing_Test->testParseLocalFile() passed TestCase XML_RSS_Parsing_Test->testGetStructure() passed TestCase XML_RSS_Parsing_Test->testGetStructureFromString() passed TestCase XML_RSS_Parsing_Test->testGetChannelInfo() passed TestCase XML_RSS_Parsing_Test->testGetItems() passed TestCase XML_RSS_Parsing_Test->testGetImages() passed TestCase XML_RSS_Parsing_Test->testGetTextinputs() passed TestCase XML_RSS_Parsing_Test->testDescriptionCdata() passed Heya Remi, this bug is still set with a status of NEW and blocking FE-REVIEW, I was wondering if you had meant to approve this? Thanks for the review :) SPEC: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-RSS.spec SRPM: http://tkmame.retrogames.com/fedora-extras/php-pear-XML-RSS-0.9.10-2.src.rpm %changelog * Thu Nov 09 2006 Christopher Stone <chris.stone> 0.9.10-2 - Added license file to %%doc - Added versioned requires the 2 "should" in comment #1 are not a blocker and are ok now. APPROVED Branch Package CVS Request ======================= Package Name: php-pear-XML-RSS Short Description: RSS parser Owners: chris.stone Branches: EL-5 InitialCC: |