Bug 2130026

Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04874231-python-mizani/python-mizani.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04874231-python-mizani/python-mizani-0.7.4-3.fc38.src.rpm

Copr Build: https://copr.fedorainfracloud.org/coprs/gui1ty/neuro-sig/build/4874231

Latest build. This one has the docs and man page included.

Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04874238-python-mizani/python-mizani.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04874238-python-mizani/python-mizani-0.7.4-3.fc38.src.rpm

Copr Build: https://copr.fedorainfracloud.org/coprs/gui1ty/neuro-sig/build/4874238

It's Monday and it's getting late :-\

Forgot to commit after applying stash... Sorry for the noise.

Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04946660-python-mizani/python-mizani.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04946660-python-mizani/python-mizani-0.8.1-1.fc38.src.rpm

Updated to latest release.

Copr Build: https://copr.fedorainfracloud.org/coprs/gui1ty/neuro-sig/build/4946660

I'll take this. Can you take one of

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2136237 - mingw-python-installer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2136238 - mingw-python-pep517

in exchange?

Since I didn't need to review anything in return for palettable and adjustText, I'll do them both. Feels fair and square. ;)

Full review below:

Some minor issues:
[!]: License file installed when any subpackage combination is installed.

=> Add the licenses also to %doc, or have it require the main package

[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
=> Document breakdown

[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
=> Not sure whether %global can be used here, in case add a justification comment for %define
     

Other comments (no action needed as far as I'm concerned):
- At your option, could use %{buildroot} rather than ${RPM_BUILD_ROOT}
- Multiple warnings emitted when building documentation due to various inventory not available (would require network access):
  - https://docs.python.org/3/objects.inv...
  - https://matplotlib.org/stable/objects.inv...
  - https://numpy.org/doc/stable/objects.inv...
  - https://docs.scipy.org/doc/scipy/objects.inv...
=> Documentation likely has broken links


Approved, but please address the first three issues before importing.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define autorelease(e:s:pb:n)
     %{?-p:0.}%{lua:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-mizani-0.8.1-1.fc38.noarch.rpm
          python-mizani-doc-0.8.1-1.fc38.noarch.rpm
          python-mizani-0.8.1-1.fc38.src.rpm
=========================================================================================================== rpmlint session starts ==========================================================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp6ekj_1kk')]
checks: 31, packages: 3

============================================================================ 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 2.4 s ===========================================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 2

 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s 



Source checksums
----------------
https://files.pythonhosted.org/packages/source/m/mizani/mizani-0.8.1.tar.gz :
  CHECKSUM(SHA256) this package     : 8ad0a0efa52f1bcdf41f675b64a8c0f7cd24e763d53baced6613f20bd6ed4928
  CHECKSUM(SHA256) upstream package : 8ad0a0efa52f1bcdf41f675b64a8c0f7cd24e763d53baced6613f20bd6ed4928


Requires
--------
python3-mizani (rpmlib, GLIBC filtered):
    python(abi)
    python3.11dist(matplotlib)
    python3.11dist(numpy)
    python3.11dist(palettable)
    python3.11dist(pandas)
    python3.11dist(scipy)

python-mizani-doc (rpmlib, GLIBC filtered):



Provides
--------
python3-mizani:
    python-mizani
    python3-mizani
    python3.11-mizani
    python3.11dist(mizani)
    python3dist(mizani)

python-mizani-doc:
    python-mizani-doc



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2130026
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, Python
Disabled plugins: Java, fonts, PHP, R, Haskell, SugarActivity, C/C++, Ocaml, Perl
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Btw MIT and Python Software Foundation License 2.0 only appear to affect the doc, so they could be installed just with the doc subpackage I suppose:

MIT License
-----------
mizani-0.8.1/doc/theme/static/bootstrap-3.4.1/css/bootstrap.min.css
mizani-0.8.1/doc/theme/static/bootstrap-3.4.1/js/bootstrap.min.js
mizani-0.8.1/licences/HUSL_LICENSE
mizani-0.8.1/licences/SIX_LICENSE

Python Software Foundation License 2.0
--------------------------------------
mizani-0.8.1/doc/_static/copybutton.js

(In reply to Sandro Mani from comment #6)
> Full review below:
> 
> Some minor issues:
> [!]: License file installed when any subpackage combination is installed.
> 
> => Add the licenses also to %doc, or have it require the main package

I chose the latter. I think that's the preferred approach.


> [!]: If the package is under multiple licenses, the licensing breakdown
>      must be documented in the spec.
> => Document breakdown

Added some comments in the specfile. Public License appears to have been abandoned. I removed it.


> [!]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %define autorelease(e:s:pb:n)
>      %{?-p:0.}%{lua:
> => Not sure whether %global can be used here, in case add a justification
> comment for %define

That's the result of using autospec. Cannot be avoided.


> Other comments (no action needed as far as I'm concerned):
> - At your option, could use %{buildroot} rather than ${RPM_BUILD_ROOT}
> - Multiple warnings emitted when building documentation due to various
> inventory not available (would require network access):
>   - https://docs.python.org/3/objects.inv...
>   - https://matplotlib.org/stable/objects.inv...
>   - https://numpy.org/doc/stable/objects.inv...
>   - https://docs.scipy.org/doc/scipy/objects.inv...
> => Documentation likely has broken links

Yeah. I haven't actually checked the contents of the documentation. :(


> Approved, but please address the first three issues before importing.

Thanks. Could you have a last glance at the current specfile. Just to make sure, I didn't do anything stupid.

Spec URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04964356-python-mizani/python-mizani.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/gui1ty/neuro-sig/fedora-rawhide-x86_64/04964356-python-mizani/python-mizani-0.8.1-2.fc38.src.rpm

LGTM!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mizani

FEDORA-2022-2edcb67276 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-2edcb67276

FEDORA-2022-2edcb67276 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.