Bug 2132273
| Summary: | Review Request: golang-github-youpy-wav - A Go library to read/write WAVE(RIFF waveform Audio) Format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robin Lee <robinlee.sysu> |
| Component: | Package Review | Assignee: | lichaoran <pkwarcraft> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, pkwarcraft |
| Target Milestone: | --- | Flags: | pkwarcraft:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-09 07:40:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2132275, 2132276 | ||
| Bug Blocks: | 1465889 | ||
|
Description
Robin Lee
2022-10-05 10:20:25 UTC
Failed to build locally: # REVIEW_NO_MOCKGROUP_CHECK=1 fedora-review -b 2132273 INFO: Processing bugzilla bug: 2132273 INFO: Getting .spec and .srpm Urls from : 2132273 INFO: --> SRPM url: https://cheeselee.fedorapeople.org/golang-github-youpy-wav-0.3.2-1.fc37.src.rpm INFO: --> Spec url: https://cheeselee.fedorapeople.org/golang-github-youpy-wav.spec INFO: Using review directory: /root/fedora-scm/2132273-golang-github-youpy-wav INFO: Downloading .spec and .srpm files INFO: Downloading (Source0): https://github.com/youpy/go-wav/archive/v0.3.2/go-wav-0.3.2.tar.gz INFO: Running checks and generating report ERROR: Exception(/root/fedora-scm/2132273-golang-github-youpy-wav/srpm/golang-github-youpy-wav-0.3.2-1.fc37.src.rpm) Config(fedora-rawhide-x86_64) 0 minutes 53 seconds INFO: Results and/or logs in: /root/fedora-scm/2132273-golang-github-youpy-wav/results ERROR: Command failed: /usr/lib/python3.11/site-packages/mockbuild/config.py:796: UserWarning: Parsing Mock configuration as root is highly discouraged, see https://rpm-software-management.github.io/mock/#setup warnings.warn( INFO: Reading configuration from /etc/mock/site-defaults.cfg INFO: Reading configuration from /etc/mock/chroot-aliases.cfg INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg ERROR: 'mock build failed, see logs in /root/fedora-scm/2132273-golang-github-youpy-wav/results' seems some dependencies are missing: # grep -rn Error: 'Some packages could no' 2132273-golang-github-youpy-wav/results/root.log -B 5 grep: Some packages could no: No such file or directory 2132273-golang-github-youpy-wav/results/root.log-1219-DEBUG util.py:442: No matching package to install: 'golang(github.com/youpy/go-riff)' 2132273-golang-github-youpy-wav/results/root.log-1220-DEBUG util.py:442: No matching package to install: 'golang(github.com/zaf/g711)' 2132273-golang-github-youpy-wav/results/root.log-1221-DEBUG util.py:444: Package compat-golang-gotest-3-devel-3.3.0-4.fc38.noarch is already installed. 2132273-golang-github-youpy-wav/results/root.log-1222-DEBUG util.py:444: Package compat-golang-gotest-3-devel-3.3.0-4.fc38.noarch is already installed. 2132273-golang-github-youpy-wav/results/root.log-1223-DEBUG util.py:442: Not all dependencies satisfied 2132273-golang-github-youpy-wav/results/root.log:1224:DEBUG util.py:442: Error: Some packages could not be found. Oh sorry, i missed the depends on stuffs, will have a look 2132276, 2132275 first Autogenerated by go2rpm, so manually check:
license: ok
mock build: ok
rpmlint: ok
latest source code: ok
---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "ISC License", "Unknown or
generated". 14 files have unknown license. Detailed output of
licensecheck in /home/mock/2132273-golang-github-youpy-
wav/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: ... so many packages seems with
reduntant dir
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 18398 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
github-youpy-wav-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: golang-github-youpy-wav-0.3.2-1.fc39.x86_64.rpm
golang-github-youpy-wav-devel-0.3.2-1.fc39.noarch.rpm
golang-github-youpy-wav-0.3.2-1.fc39.src.rpm
========================================================================================================= rpmlint session starts ========================================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0eubzag5')]
checks: 31, packages: 3
golang-github-youpy-wav.x86_64: W: no-manual-page-for-binary benchmark
golang-github-youpy-wav-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/youpy/go-wav/.goipath
golang-github-youpy-wav-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/youpy/go-wav/README.md /usr/share/doc/golang-github-youpy-wav-devel/README.md
========================================================================== 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.4 s =========================================================================
Rpmlint (debuginfo)
-------------------
Checking: golang-github-youpy-wav-debuginfo-0.3.2-1.fc39.x86_64.rpm
========================================================================================================= rpmlint session starts ========================================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpadfqvcw6')]
checks: 31, packages: 1
========================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s =========================================================================
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
golang-github-youpy-wav.x86_64: W: no-manual-page-for-binary benchmark
golang-github-youpy-wav-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/youpy/go-wav/.goipath
golang-github-youpy-wav-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/youpy/go-wav/README.md /usr/share/doc/golang-github-youpy-wav-devel/README.md
3 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.4 s
Source checksums
----------------
https://github.com/youpy/go-wav/archive/v0.3.2/go-wav-0.3.2.tar.gz :
CHECKSUM(SHA256) this package : 9008a1cf71c35648630b3b1294b7fa6e888413974fe2530869d65ec33b92623f
CHECKSUM(SHA256) upstream package : 9008a1cf71c35648630b3b1294b7fa6e888413974fe2530869d65ec33b92623f
Requires
--------
golang-github-youpy-wav (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
rtld(GNU_HASH)
golang-github-youpy-wav-devel (rpmlib, GLIBC filtered):
go-filesystem
golang(github.com/youpy/go-riff)
golang(github.com/zaf/g711)
Provides
--------
golang-github-youpy-wav:
golang-github-youpy-wav
golang-github-youpy-wav(x86-64)
golang-github-youpy-wav-devel:
golang(github.com/youpy/go-wav)
golang-github-youpy-wav-devel
golang-ipath(github.com/youpy/go-wav)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2132273
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Perl, Ocaml, SugarActivity, Java, R, fonts, C/C++, Haskell, Python, PHP
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-youpy-wav FEDORA-2023-9c278e83ee has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9c278e83ee FEDORA-2023-9c278e83ee has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-310fda9c8d has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-310fda9c8d FEDORA-2023-310fda9c8d has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |