Spec URL: https://cheeselee.fedorapeople.org/golang-github-zaf-g711.spec SRPM URL: https://cheeselee.fedorapeople.org/golang-github-zaf-g711-1.2-1.fc37.src.rpm Description: Go package to encode and decode ITU-T G.711 sound data. Fedora Account System Username: cheeselee
My local review build failed: # REVIEW_NO_MOCKGROUP_CHECK=1 fedora-review -b 2132276 INFO: Processing bugzilla bug: 2132276 INFO: Getting .spec and .srpm Urls from : 2132276 INFO: --> SRPM url: https://cheeselee.fedorapeople.org/golang-github-zaf-g711-1.2-1.fc37.src.rpm INFO: --> Spec url: https://cheeselee.fedorapeople.org/golang-github-zaf-g711.spec INFO: Using review directory: /root/fedora-scm/2132276-golang-github-zaf-g711 INFO: Downloading .spec and .srpm files INFO: Downloading (Source0): https://github.com/zaf/g711/archive/v1.2/g711-1.2.tar.gz INFO: Running checks and generating report INFO: Results and/or logs in: /root/fedora-scm/2132276-golang-github-zaf-g711/results /usr/lib/python3.11/site-packages/mockbuild/config.py:796: UserWarning: Parsing Mock configuration as root is highly discouraged, see https://rpm-software-management.github.io/mock/#setup warnings.warn( INFO: Reading configuration from /etc/mock/site-defaults.cfg INFO: Reading configuration from /etc/mock/chroot-aliases.cfg INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg INFO: Build completed INFO: Installing built package(s) INFO: Active plugins: Shell-api, Generic Cache-only enabled but no cache for repository "fedora" ERROR: Exception down the road... (logs in /root/.cache/fedora-review.log) # cat /root/.cache/fedora-review.log ... Start: chroot ['rpm -i golang-github-zaf-g711-1.2-1.fc37.src.rpm; rpmbuild --nodeps -bp $(rpm --eval %_specdir)/golang-github-zaf-g711.spec;chmod -R go+r $(rpm --eval %_builddir)/* || :'] warning: user cheese does not exist - using root warning: group cheese does not exist - using root warning: user cheese does not exist - using root warning: group cheese does not exist - using root setting SOURCE_DATE_EPOCH=1691366400 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.FeFxD4 + umask 022 + cd /builddir/build/BUILD + %goprep /var/tmp/rpm-tmp.FeFxD4: line 34: fg: no job control RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.FeFxD4 (%prep) Bad exit status from /var/tmp/rpm-tmp.FeFxD4 (%prep) chmod: cannot access '/builddir/build/BUILD/*': No such file or directory Finish: chroot ['rpm -i golang-github-zaf-g711-1.2-1.fc37.src.rpm; rpmbuild --nodeps -bp $(rpm --eval %_specdir)/golang-github-zaf-g711.spec;chmod -R go+r $(rpm --eval %_builddir)/* || :'] None ... Seems some macros are missing in go2rpm autogenerated spec
If you don't run fedora-review with mock, you should install buildeps manually first.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "BSD 3-Clause License", "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/mock/2132276-golang-github- zaf-g711/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: ... so many package, have to prune them to meet the words limits [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [?]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang- github-zaf-g711-devel [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-zaf-g711-1.2-1.fc39.x86_64.rpm golang-github-zaf-g711-devel-1.2-1.fc39.noarch.rpm golang-github-zaf-g711-1.2-1.fc39.src.rpm ========================================================================================================== rpmlint session starts ========================================================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxh3wszjr')] checks: 31, packages: 3 golang-github-zaf-g711.x86_64: W: no-manual-page-for-binary g711dec golang-github-zaf-g711.x86_64: W: no-manual-page-for-binary g711enc golang-github-zaf-g711-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zaf/g711/.goipath golang-github-zaf-g711-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/zaf/g711/Readme.md /usr/share/doc/golang-github-zaf-g711-devel/Readme.md =========================================================================== 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.4 s ========================================================================== Rpmlint (debuginfo) ------------------- Checking: golang-github-zaf-g711-debuginfo-1.2-1.fc39.x86_64.rpm ========================================================================================================== rpmlint session starts ========================================================================================================= rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphuvy9vlm')] checks: 31, packages: 1 =========================================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s ========================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 golang-github-zaf-g711.x86_64: W: no-manual-page-for-binary g711dec golang-github-zaf-g711.x86_64: W: no-manual-page-for-binary g711enc golang-github-zaf-g711-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/zaf/g711/.goipath golang-github-zaf-g711-devel.noarch: W: files-duplicate /usr/share/gocode/src/github.com/zaf/g711/Readme.md /usr/share/doc/golang-github-zaf-g711-devel/Readme.md 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.8 s Source checksums ---------------- https://github.com/zaf/g711/archive/v1.2/g711-1.2.tar.gz : CHECKSUM(SHA256) this package : d5b8ae60aebc81c5d35ce5dbafc81832488c703d70fbac54351de613d06ff624 CHECKSUM(SHA256) upstream package : d5b8ae60aebc81c5d35ce5dbafc81832488c703d70fbac54351de613d06ff624 Requires -------- golang-github-zaf-g711 (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) golang-github-zaf-g711-devel (rpmlib, GLIBC filtered): go-filesystem Provides -------- golang-github-zaf-g711: golang-github-zaf-g711 golang-github-zaf-g711(x86-64) golang-github-zaf-g711-devel: golang(github.com/zaf/g711) golang-github-zaf-g711-devel golang-ipath(github.com/zaf/g711) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2132276 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Python, fonts, Perl, C/C++, Java, PHP, Ocaml, Haskell, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH --- manually checks as autogenerated by go2rpm: license: ok latest source code: ok rpmlint no error: ok build in mock: ok
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-zaf-g711
FEDORA-2023-fc6f8c373f has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fc6f8c373f
FEDORA-2023-fc6f8c373f has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.