Bug 2132377
| Summary: | Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Anthony Rabbito <hello> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-13 17:54:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2130734 | ||
|
Description
Anthony Rabbito
2022-10-05 12:59:12 UTC
Updated spec with `gosourcedir0` Spec URL: https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-integrations-cobra/golang-github-withfig-autocomplete-tools-integrations-cobra.spec SRPM URL: https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-integrations-cobra/golang-github-withfig-autocomplete-tools-integrations-cobra-0-1.20221005git41b7753.fc37.src.rpm Spec is correct, but there is one issue with the README.md files, as you've two and it complains about duplicated file. You can fix this by doing in %prep something like `mv integrations/cobra/README.md README-cobra.md` and adjust `%global godocs` to the new name. Good catch :-) I also added > autorelease -p The licenses was also an issue. Spec URL: https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-integrations-cobra/golang-github-withfig-autocomplete-tools-integrations-cobra.spec SRPM URL: https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools-integrations-cobra/golang-github-withfig-autocomplete-tools-integrations-cobra-0-0.1.20221005git41b7753.fc37.src.rpm thanks for fixing also the Liencese and autorelease parts. go2rpm package that requires changing gosourcedir0: - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-withfig-autocomplete-tools-integrations-cobra FEDORA-2022-006cf951f8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-006cf951f8 FEDORA-2022-006cf951f8 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |