Bug 2132377 - Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell
Summary: Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra -...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2130734
TreeView+ depends on / blocked
 
Reported: 2022-10-05 12:59 UTC by Anthony Rabbito
Modified: 2022-10-13 17:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-10-13 17:54:03 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Comment 2 Mikel Olasagasti Uranga 2022-10-08 08:32:36 UTC
Spec is correct, but there is one issue with the README.md files, as you've two and it complains about duplicated file.

You can fix this by doing in %prep something like `mv integrations/cobra/README.md README-cobra.md` and adjust `%global godocs` to the new name.

Comment 4 Mikel Olasagasti Uranga 2022-10-08 15:08:41 UTC
thanks for fixing also the Liencese and autorelease parts.

go2rpm package that requires changing gosourcedir0:

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 5 Gwyn Ciesla 2022-10-10 13:39:46 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-withfig-autocomplete-tools-integrations-cobra

Comment 6 Fedora Update System 2022-10-13 17:52:47 UTC
FEDORA-2022-006cf951f8 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-006cf951f8

Comment 7 Fedora Update System 2022-10-13 17:54:03 UTC
FEDORA-2022-006cf951f8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.