Bug 2132721
| Summary: | Delete dialogs | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Leon Kladnitsky <lkladnit> |
| Component: | User Experience | Assignee: | Hilda Stastna <hstastna> |
| Status: | CLOSED ERRATA | QA Contact: | Leon Kladnitsky <lkladnit> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.12.0 | CC: | hstastna |
| Target Milestone: | --- | ||
| Target Release: | 4.12.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-24 13:41:21 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Leon Kladnitsky
2022-10-06 13:14:33 UTC
Hi Leon, just to let you know, here are the guidelines we should follow for the dialogs: https://www.patternfly.org/v4/components/modal/design-guidelines/#content-considerations https://www.patternfly.org/v4/components/modal/design-guidelines/#confirm-a-destructive-action The buttons should remain on the left side of the dialogs. Also from the discussion with Yifat: "We don’t include “VirtualMachines” or “template” in the buttons names and also not in the kebab menus. This is done to unclutter the UI." Regarding the VM or any other name in the dialog title/heading, I got the info from Yifat that we should better keep it: "The reason is that it helps the users to better focus on the action they are about to do and make sure they avoid mistakes. That’s what makes the difference between a general message and a pointed one that really draws their attention to the consequences." Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo. So I suggest to create a separate BZ for other than "Virtualization" related dialogs. Another note: I am not sure what's the difference between points 5. and 8. from the description of this BZ - it looks the same, but that issue doesn't not belong to the kubevirt-plugin repo anyway. > Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo.
> So I suggest to create a separate BZ for other than "Virtualization" related dialogs.
Same for the "Delete PersistentVolumeClaim" dialog, point 10.
Affected delete dialogs missing in the description of the BZ: - Delete VM template dialog - Delete VM template disk dialog - Delete NIC dialog while customizing VM - Delete VM Snapshot from the Snapshots card in the Overview tab > Regarding the VM or any other name in the dialog title/heading, I got the info from Yifat that we should better keep it:
> "The reason is that it helps the users to better focus on the action they are about to do and make sure they avoid mistakes.
> That’s what makes the difference between a general message and a pointed one that really draws their attention to the consequences."
We've re-discussed this topic with Yifat, and because of the titles' inconsistencies not only in the delete dialogs, we've decided to leave the dialogs titles as they are for now,
and to continue with looking for the best option for dialog titles in a separate BZ, as there is another option: showing the name in a smaller font and have the title over 2 lines.
(In reply to Hilda Stastna from comment #18) > Affected delete dialogs missing in the description of the BZ: > - Delete VM template dialog > - Delete VM template disk dialog > - Delete NIC dialog while customizing VM > - Delete VM Snapshot from the Snapshots card in the Overview tab Agree. (In reply to Hilda Stastna from comment #17) > > Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo. > > So I suggest to create a separate BZ for other than "Virtualization" related dialogs. > > Same for the "Delete PersistentVolumeClaim" dialog, point 10. Ok, got it (In reply to Hilda Stastna from comment #14) > Regarding the VM or any other name in the dialog title/heading, I got the > info from Yifat that we should better keep it: > "The reason is that it helps the users to better focus on the action they > are about to do and make sure they avoid mistakes. > That’s what makes the difference between a general message and a pointed one > that really draws their attention to the consequences." Agree, but than it probably should be the same in dialogs for other entities too. Verified on v4.12.0-151 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:0408 |