Description of problem: Some Delete popups are missing texts. I joined them all in a single bug Version-Release number of selected component (if applicable): as of v4.12.0-131 How reproducible: always Affected dialogs: 1. Delete VM: question sign is missing in title, VM name is redundant in title 2. Delete VM NIC: question sign is missing in title, kebab menu is missing "NIC" in items 3. Delete VM Template NIC: question sign is missing in title, the message is cut, kebab menu is missing "NIC" in items 4. Delete VirtualMachineSnapshot: question sign is missing in title, kebab menu item should say "Restore VirtualMachineSnapshot" 5. Delete DataImportCron: close button is missing 6. Delete MigrationPolicy: "in namespace" text is redundant, kebab menu is missing MigrationPolicy in items 7. Delete NAD: question sign is missing in title, close button is missing, Create button should say "Create NAD", kebab menu should say NAD or "NetworkAttachmentDefinition" as single word, wherever not abbreviated 8. Delete DataImportCron: close button is missing 9. Edit BSR: text is missing, probably "all templates" 10. Delete PVC: close button is missing, question sign is missing in title, namespace is not mentioned in confimation question, kebab menu uses both "PVC" and "PersistentVolumeClaim" 11. Detach VM disk: question sign is missing in title, disk name is redundant in title, kebab menu is missing "disk" in items. Actual results: Expected results: Additional info:
Hi Leon, just to let you know, here are the guidelines we should follow for the dialogs: https://www.patternfly.org/v4/components/modal/design-guidelines/#content-considerations https://www.patternfly.org/v4/components/modal/design-guidelines/#confirm-a-destructive-action The buttons should remain on the left side of the dialogs. Also from the discussion with Yifat: "We don’t include “VirtualMachines” or “template” in the buttons names and also not in the kebab menus. This is done to unclutter the UI."
Regarding the VM or any other name in the dialog title/heading, I got the info from Yifat that we should better keep it: "The reason is that it helps the users to better focus on the action they are about to do and make sure they avoid mistakes. That’s what makes the difference between a general message and a pointed one that really draws their attention to the consequences."
Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo. So I suggest to create a separate BZ for other than "Virtualization" related dialogs.
Another note: I am not sure what's the difference between points 5. and 8. from the description of this BZ - it looks the same, but that issue doesn't not belong to the kubevirt-plugin repo anyway.
> Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo. > So I suggest to create a separate BZ for other than "Virtualization" related dialogs. Same for the "Delete PersistentVolumeClaim" dialog, point 10.
Affected delete dialogs missing in the description of the BZ: - Delete VM template dialog - Delete VM template disk dialog - Delete NIC dialog while customizing VM - Delete VM Snapshot from the Snapshots card in the Overview tab
> Regarding the VM or any other name in the dialog title/heading, I got the info from Yifat that we should better keep it: > "The reason is that it helps the users to better focus on the action they are about to do and make sure they avoid mistakes. > That’s what makes the difference between a general message and a pointed one that really draws their attention to the consequences." We've re-discussed this topic with Yifat, and because of the titles' inconsistencies not only in the delete dialogs, we've decided to leave the dialogs titles as they are for now, and to continue with looking for the best option for dialog titles in a separate BZ, as there is another option: showing the name in a smaller font and have the title over 2 lines.
(In reply to Hilda Stastna from comment #18) > Affected delete dialogs missing in the description of the BZ: > - Delete VM template dialog > - Delete VM template disk dialog > - Delete NIC dialog while customizing VM > - Delete VM Snapshot from the Snapshots card in the Overview tab Agree.
(In reply to Hilda Stastna from comment #17) > > Also note that "Network Attachment Definitions" belong to "Networking", not "Virtualization", don't belong to the kubevirt-plugin repo. > > So I suggest to create a separate BZ for other than "Virtualization" related dialogs. > > Same for the "Delete PersistentVolumeClaim" dialog, point 10. Ok, got it
(In reply to Hilda Stastna from comment #14) > Regarding the VM or any other name in the dialog title/heading, I got the > info from Yifat that we should better keep it: > "The reason is that it helps the users to better focus on the action they > are about to do and make sure they avoid mistakes. > That’s what makes the difference between a general message and a pointed one > that really draws their attention to the consequences." Agree, but than it probably should be the same in dialogs for other entities too.
Verified on v4.12.0-151
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:0408