Bug 213282

Summary: SDL_image crashed on IMG_ReadXPMFromArray
Product: [Fedora] Fedora Reporter: simon
Component: SDL_imageAssignee: Brian Pepple <bdpepple>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 6CC: wart
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.2.5-3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-11-26 15:39:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 198839, 213321    
Attachments:
Description Flags
Test code
none
one way to patch it
none
Mock Build Log
none
Mock Root Log none

Description simon 2006-10-31 16:16:58 UTC 
Description of problem:
A segfault occurs when calling IMG_ReadXPMFromArray. This has worked fine in
previous SDL_image versions (e.g. 1.2.4 in FC5).
I have attached some sample code to replicate this issue.

compile with gcc test.cpp -o test -I /usr/include/SDL -lstdc++ -lSDL -lSDL_image
and run with ./test

Version-Release number of selected component (if applicable):
SDL_image-1.2.5-2.fc6

How reproducible:
Always

Steps to Reproduce:
1. Install SDL_image-devel
2. extract tar.gz containing source file
3. gcc test.cpp -o test -I /usr/include/SDL -lstdc++ -lSDL -lSDL_image
4. ./test
  
Actual results:
Segmentation fault

Expected results:
Some output text.


Additional info:
Comment 1 simon 2006-10-31 16:17:06 UTC 
Created attachment 139870 [details]
Test code
Comment 2 Michael Schwendt 2006-10-31 18:09:19 UTC 
Created attachment 139880 [details]
one way to patch it

Confirmed. It's an upstream bug.

The included "showimage" demo program also fails if built with
-DXPM_INCLUDED defined.

Here's one way to patch it as a work-around. SDL_RWtell(..) is a
macro which cannot be called with a NULL pointer as argument.
Comment 3 Brian Pepple 2006-11-01 18:21:45 UTC 
Michael, thanks for the patch.

SDL_image is failing to build in mock right now (probably due to a missing BR,
since the main SDL package was updated recently), and hopefully I can get some
free time this weekend to investigate what the problem is.  Once I figure that
out, I'll apply your patch.
Comment 4 simon 2006-11-21 09:42:23 UTC 
I've tried the patch against the current src rpm and it fixed my issue.
Comment 5 Brian Pepple 2006-11-21 15:21:46 UTC 
Did you try building it in mock?  Something changed in the SDL package, and I
haven't had a chance to figure out what BR needs to be added to get SDL_image to
build again.
Comment 6 Michael Schwendt 2006-11-21 16:07:52 UTC 
Can you provide a build log?
Comment 7 Brian Pepple 2006-11-21 17:00:23 UTC 
Created attachment 141793 [details]
Mock Build Log
Comment 8 Brian Pepple 2006-11-21 17:02:21 UTC 
Created attachment 141794 [details]
Mock Root Log

Michael, if you don't have time to look this, I should probably have some time
this weekend.
Comment 9 Michael Schwendt 2006-11-21 18:46:48 UTC 
Cannot reproduce. It fails in a simple AC_TRY_LINK check for SDL.
Package "SDL" is unchanged since July 27th.
Comment 10 Michael Schwendt 2006-11-25 15:16:04 UTC 
SDL_image rebuilds flawlessly for FC-6:
http://buildsys.fedoraproject.org/build-status/job.psp?uid=22289

checking for sdl-config... /usr/bin/sdl-config
checking for SDL - version >= 1.2.10... yes

No idea what local problems you have run into

I'm going to remove the test-build from the needsign queue.
Comment 11 Brian Pepple 2006-11-25 15:31:21 UTC 
(In reply to comment #10)
> SDL_image rebuilds flawlessly for FC-6:
> http://buildsys.fedoraproject.org/build-status/job.psp?uid=22289
> 
> checking for sdl-config... /usr/bin/sdl-config
> checking for SDL - version >= 1.2.10... yes
> 
> No idea what local problems you have run into

Hmm, that's odd since I was building it in Mock (Look at the attached build log
from 2006-11-21).
Comment 12 Brian Pepple 2006-11-26 15:39:17 UTC 
Not sure what's causing problems with the mock build, but regardless the build
system seems to be fine.  Fixed with in 1.2.5-3 which should be available with
the next FE push.  Thanks for the patch Michael.