Description of problem: A segfault occurs when calling IMG_ReadXPMFromArray. This has worked fine in previous SDL_image versions (e.g. 1.2.4 in FC5). I have attached some sample code to replicate this issue. compile with gcc test.cpp -o test -I /usr/include/SDL -lstdc++ -lSDL -lSDL_image and run with ./test Version-Release number of selected component (if applicable): SDL_image-1.2.5-2.fc6 How reproducible: Always Steps to Reproduce: 1. Install SDL_image-devel 2. extract tar.gz containing source file 3. gcc test.cpp -o test -I /usr/include/SDL -lstdc++ -lSDL -lSDL_image 4. ./test Actual results: Segmentation fault Expected results: Some output text. Additional info:
Created attachment 139870 [details] Test code
Created attachment 139880 [details] one way to patch it Confirmed. It's an upstream bug. The included "showimage" demo program also fails if built with -DXPM_INCLUDED defined. Here's one way to patch it as a work-around. SDL_RWtell(..) is a macro which cannot be called with a NULL pointer as argument.
Michael, thanks for the patch. SDL_image is failing to build in mock right now (probably due to a missing BR, since the main SDL package was updated recently), and hopefully I can get some free time this weekend to investigate what the problem is. Once I figure that out, I'll apply your patch.
I've tried the patch against the current src rpm and it fixed my issue.
Did you try building it in mock? Something changed in the SDL package, and I haven't had a chance to figure out what BR needs to be added to get SDL_image to build again.
Can you provide a build log?
Created attachment 141793 [details] Mock Build Log
Created attachment 141794 [details] Mock Root Log Michael, if you don't have time to look this, I should probably have some time this weekend.
Cannot reproduce. It fails in a simple AC_TRY_LINK check for SDL. Package "SDL" is unchanged since July 27th.
SDL_image rebuilds flawlessly for FC-6: http://buildsys.fedoraproject.org/build-status/job.psp?uid=22289 checking for sdl-config... /usr/bin/sdl-config checking for SDL - version >= 1.2.10... yes No idea what local problems you have run into I'm going to remove the test-build from the needsign queue.
(In reply to comment #10) > SDL_image rebuilds flawlessly for FC-6: > http://buildsys.fedoraproject.org/build-status/job.psp?uid=22289 > > checking for sdl-config... /usr/bin/sdl-config > checking for SDL - version >= 1.2.10... yes > > No idea what local problems you have run into Hmm, that's odd since I was building it in Mock (Look at the attached build log from 2006-11-21).
Not sure what's causing problems with the mock build, but regardless the build system seems to be fine. Fixed with in 1.2.5-3 which should be available with the next FE push. Thanks for the patch Michael.