Bug 213498
Summary: | cups segmentation fault on lpq cancel job | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael Sellers <msellers> |
Component: | cups | Assignee: | Tim Waugh <twaugh> |
Status: | CLOSED ERRATA | QA Contact: | |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 6 | CC: | ajschult784, keith.holmes, mra |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 1.2.5-2.fc6.8 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-11-09 16:04:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 207681 |
Description
Michael Sellers
2006-11-01 17:42:28 UTC
CC: Matt Matt, shouldn't that whole section in cupsdSaveJob be wrapped in 'if (is_lspp_config())' anyway? But it looks like there is a missing '!job->scon ||' as well -- what do you think? My proposed minimal fix: --- cups-1.2.4/scheduler/job.c 2006-10-16 15:30:02.000000000 -0400 +++ cups-1.2.5/scheduler/job.c 2006-11-01 18:16:18.000000000 +0000 @@ -1395,7 +1395,7 @@ fchown(cupsFileNumber(fp), RunUser, Group); #ifdef WITH_LSPP - if (strncmp(job->scon, UNKNOWN_SL, strlen(UNKNOWN_SL)) != 0) + if (job->scon && strncmp(job->scon, UNKNOWN_SL, strlen(UNKNOWN_SL)) != 0) { if (getfilecon(filename, &spoolcon) == -1) { but I expect that whole 'if' clause should be in an 'if (is_lspp_config())' conditional as well. I think your proposed minimal fix is best. Since this is occuring in cupsdSaveJob() we need it to honor the job->scon if it exists, regardless of how the server is configured at the moment. Fixed in CVS for FC-6 and devel. Please try this test update: https://www.redhat.com/archives/fedora-test-list/2006-November/msg00043.html You can do this with: yum --enablerepo=updates-testing update 'cups*' Stopping cups: [FAILED] Starting cups: [ OK ] [root@halogen init.d]# lpq toby is ready and printing Rank Owner Job File(s) Total Size active mseller 10 evince-print 250880 bytes [root@halogen init.d]# cancel 10 [root@halogen init.d]# lpq toby is ready no entries [root@halogen init.d]# ./cups status cupsd (pid 32332) is running... *** Bug 213735 has been marked as a duplicate of this bug. *** |