Bug 2138263
| Summary: | Review Request: rust-pretty-bytes - Convert bytes to a human readable string | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, decathorpe, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-11-05 16:59:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2132765 | ||
|
Description
Michel Lind
2022-10-27 20:03:07 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=93494387 (pretty sure the x86_64 failure is spurious, works fine in mock locally and all other arches pass) Added license breakdown Spec URL: https://salimma.fedorapeople.org/rust-pretty-bytes.spec SRPM URL: https://salimma.fedorapeople.org/rust-pretty-bytes-0.2.0-1.fc37.src.rpm Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. Thanks! ❯ fedpkg request-repo rust-pretty-bytes 2138263 https://pagure.io/releng/fedora-scm-requests/issue/48456 ❯ fedpkg request-branch --repo rust-pretty-bytes --all-releases https://pagure.io/releng/fedora-scm-requests/issue/48457 https://pagure.io/releng/fedora-scm-requests/issue/48458 https://pagure.io/releng/fedora-scm-requests/issue/48459 Do you actually need the pretty-bytes binary for below, or just the library interface? If it's the latter, you should be able to drop the binary - that would make the packaging easier (no need for the license breakdown etc.) and builds faster. (In reply to Fabio Valentini from comment #5) > Do you actually need the pretty-bytes binary for below, or just the library > interface? > If it's the latter, you should be able to drop the binary - that would make > the packaging easier (no need for the license breakdown etc.) and builds > faster. Probably just the library interface - at least for now. Is there an easy way to drop the binary? (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pretty-bytes (In reply to Michel Alexandre Salim from comment #6) > Probably just the library interface - at least for now. Is there an easy way > to drop the binary? In simple cases like this, adding the setting "autobins = false" to the "[package]" table in Cargo.toml is enough. That will prevent the binary from being built, and it will cause rust2rpm to not generate the binary subpackage. FEDORA-2022-33a6c617a1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-33a6c617a1 FEDORA-2022-1b494c51f1 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1b494c51f1 FEDORA-2022-71155f6a8a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71155f6a8a FEDORA-2022-33a6c617a1 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-33a6c617a1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-33a6c617a1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-1b494c51f1 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1b494c51f1 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1b494c51f1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-71155f6a8a has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71155f6a8a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71155f6a8a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-1b494c51f1 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-71155f6a8a has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-33a6c617a1 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |