Bug 2138263 - Review Request: rust-pretty-bytes - Convert bytes to a human readable string
Summary: Review Request: rust-pretty-bytes - Convert bytes to a human readable string
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: rust-below-0.6.2
TreeView+ depends on / blocked
 
Reported: 2022-10-27 20:03 UTC by Michel Lind
Modified: 2022-11-10 22:27 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-11-05 16:59:32 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-10-27 20:03:07 UTC
Spec URL: https://salimma.fedorapeople.org/rust-pretty-bytes.spec
SRPM URL: https://salimma.fedorapeople.org/rust-pretty-bytes-0.2.0-1.fc36.src.rpm

Description:
Convert bytes to a human readable string.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-10-27 20:03:47 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=93494387

(pretty sure the x86_64 failure is spurious, works fine in mock locally and all other arches pass)

Comment 3 Davide Cavalca 2022-10-27 20:24:38 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Michel Lind 2022-10-27 20:26:50 UTC
Thanks!

❯ fedpkg request-repo rust-pretty-bytes 2138263
https://pagure.io/releng/fedora-scm-requests/issue/48456

❯ fedpkg request-branch --repo rust-pretty-bytes --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/48457
https://pagure.io/releng/fedora-scm-requests/issue/48458
https://pagure.io/releng/fedora-scm-requests/issue/48459

Comment 5 Fabio Valentini 2022-10-27 20:31:10 UTC
Do you actually need the pretty-bytes binary for below, or just the library interface?
If it's the latter, you should be able to drop the binary - that would make the packaging easier (no need for the license breakdown etc.) and builds faster.

Comment 6 Michel Lind 2022-10-27 20:45:31 UTC
(In reply to Fabio Valentini from comment #5)
> Do you actually need the pretty-bytes binary for below, or just the library
> interface?
> If it's the latter, you should be able to drop the binary - that would make
> the packaging easier (no need for the license breakdown etc.) and builds
> faster.

Probably just the library interface - at least for now. Is there an easy way to drop the binary?

Comment 7 Gwyn Ciesla 2022-10-27 20:46:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pretty-bytes

Comment 8 Fabio Valentini 2022-10-27 20:49:28 UTC
(In reply to Michel Alexandre Salim from comment #6)
> Probably just the library interface - at least for now. Is there an easy way
> to drop the binary?

In simple cases like this, adding the setting "autobins = false" to the "[package]" table in Cargo.toml is enough. That will prevent the binary from being built, and it will cause rust2rpm to not generate the binary subpackage.

Comment 9 Fedora Update System 2022-10-28 01:15:09 UTC
FEDORA-2022-33a6c617a1 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-33a6c617a1

Comment 10 Fedora Update System 2022-10-28 01:15:10 UTC
FEDORA-2022-1b494c51f1 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1b494c51f1

Comment 11 Fedora Update System 2022-10-28 01:15:11 UTC
FEDORA-2022-71155f6a8a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-71155f6a8a

Comment 12 Fedora Update System 2022-10-28 09:01:44 UTC
FEDORA-2022-33a6c617a1 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-33a6c617a1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-33a6c617a1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-10-28 12:29:10 UTC
FEDORA-2022-1b494c51f1 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-1b494c51f1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-1b494c51f1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-10-28 12:32:48 UTC
FEDORA-2022-71155f6a8a has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-71155f6a8a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-71155f6a8a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-11-05 16:59:32 UTC
FEDORA-2022-1b494c51f1 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-11-05 17:06:08 UTC
FEDORA-2022-71155f6a8a has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2022-11-10 22:27:32 UTC
FEDORA-2022-33a6c617a1 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.