Bug 2138409
| Summary: | Review Request: rust-concat-idents - Allows concatenating multiple identifiers and using them everywhere | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, rjones |
| Target Milestone: | --- | Flags: | rjones:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-28 20:45:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2124697 | ||
|
Description
Fabio Valentini
2022-10-28 16:06:28 UTC
The package was generated by a trusted maintainer using rust2rpm so I'm going to do a reduced review. Upstream: https://github.com/DzenanJupic/concat-idents The latest version (1.1.3) is packaged. Fabio has included the license files as separate files, but that's OK because he has filed a PR upstream to get those included next time: https://github.com/DzenanJupic/concat-idents/pull/1 The license is correct, matching the upstream package, and is permitted by Fedora. Apart from the license thing there are no downstream changes. The spec file is legible, matches the packaging guidelines, and is largely generated. There are some test failures, but the tests are disabled (with a bcond to enable them) and the reason is documented in the spec file. The scratch build was successful. I downloaded and tested the package by building libblkio against it (see bug 2124697) and that went well. *** This package is APPROVED for Fedora by rjones *** Thanks! https://pagure.io/releng/fedora-scm-requests/issue/48477 https://pagure.io/releng/fedora-scm-requests/issue/48478 https://pagure.io/releng/fedora-scm-requests/issue/48479 https://pagure.io/releng/fedora-scm-requests/issue/48480 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-concat-idents |