Bug 2138409 - Review Request: rust-concat-idents - Allows concatenating multiple identifiers and using them everywhere
Summary: Review Request: rust-concat-idents - Allows concatenating multiple identifier...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2124697
TreeView+ depends on / blocked
 
Reported: 2022-10-28 16:06 UTC by Fabio Valentini
Modified: 2022-10-28 20:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-28 20:45:33 UTC
Type: ---
Embargoed:
rjones: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2022-10-28 16:06:28 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-concat-idents.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-concat-idents-1.1.3-1.fc37.src.rpm

Description:
Allows concatenating multiple identifiers and using them everywhere.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=93527674

Comment 1 Richard W.M. Jones 2022-10-28 17:09:22 UTC
The package was generated by a trusted maintainer using rust2rpm so I'm
going to do a reduced review.

Upstream: https://github.com/DzenanJupic/concat-idents

The latest version (1.1.3) is packaged.

Fabio has included the license files as separate files, but that's OK
because he has filed a PR upstream to get those included next time:
https://github.com/DzenanJupic/concat-idents/pull/1

The license is correct, matching the upstream package, and is permitted by Fedora.

Apart from the license thing there are no downstream changes.

The spec file is legible, matches the packaging guidelines, and is
largely generated.

There are some test failures, but the tests are disabled (with a bcond
to enable them) and the reason is documented in the spec file.

The scratch build was successful.

I downloaded and tested the package by building libblkio against
it (see bug 2124697) and that went well.

Comment 2 Richard W.M. Jones 2022-10-28 17:13:46 UTC
*** This package is APPROVED for Fedora by rjones ***

Comment 4 Gwyn Ciesla 2022-10-28 19:00:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-concat-idents


Note You need to log in before you can comment on or make changes to this bug.