Bug 2138410
| Summary: | Review Request: rust-pci-driver - PCI/PCIe driver development library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | afaria, package-review, rjones |
| Target Milestone: | --- | Flags: | rjones:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-10-28 20:46:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2124697 | ||
|
Description
Fabio Valentini
2022-10-28 16:12:45 UTC
The package was generated by a trusted maintainer using rust2rpm so I'm going to do a reduced review. Upstream: https://gitlab.com/pci-driver/pci-driver The latest version is 0.1.2 which is the version being packaged. The license tag is correct, matches upstream, and is permitted by Fedora. There are no downstream changes at all. The spec file is legible, matches the packaging guidelines, and is largely generated. Some tests fail. The reason is documented in the spec and a switch is provided to enable the tests (disabled by default). I downloaded and tested the package by compiling libblkio against it (see bug 2124697) and that worked fine. *** This package is APPROVED by rjones *** Thanks! https://pagure.io/releng/fedora-scm-requests/issue/48481 https://pagure.io/releng/fedora-scm-requests/issue/48482 https://pagure.io/releng/fedora-scm-requests/issue/48483 https://pagure.io/releng/fedora-scm-requests/issue/48484 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pci-driver |