Bug 2138410 - Review Request: rust-pci-driver - PCI/PCIe driver development library
Summary: Review Request: rust-pci-driver - PCI/PCIe driver development library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2124697
TreeView+ depends on / blocked
 
Reported: 2022-10-28 16:12 UTC by Fabio Valentini
Modified: 2022-11-02 01:49 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-10-28 20:46:29 UTC
Type: ---
Embargoed:
rjones: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2022-10-28 16:12:45 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-pci-driver.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-pci-driver-0.1.2-1.fc37.src.rpm

Description:
PCI/PCIe driver development library.

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=93528203

Note: Tests are disabled, because enabling tests would require packaging two additional crates (byte-strings, byte-strings-proc_macros), which is usually not worth it just to enable tests in just one package. This can be re-evaluated if / when other packages also add dependencies on these two.

Comment 1 Richard W.M. Jones 2022-10-28 17:13:21 UTC
The package was generated by a trusted maintainer using rust2rpm so I'm
going to do a reduced review.

Upstream: https://gitlab.com/pci-driver/pci-driver

The latest version is 0.1.2 which is the version being packaged.

The license tag is correct, matches upstream, and is permitted by Fedora.

There are no downstream changes at all.

The spec file is legible, matches the packaging guidelines, and is
largely generated.

Some tests fail.  The reason is documented in the spec and a switch
is provided to enable the tests (disabled by default).

I downloaded and tested the package by compiling libblkio against it
(see bug 2124697) and that worked fine.

Comment 2 Richard W.M. Jones 2022-10-28 17:13:59 UTC
*** This package is APPROVED by rjones ***

Comment 4 Gwyn Ciesla 2022-10-28 19:01:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pci-driver


Note You need to log in before you can comment on or make changes to this bug.