Bug 2138969
| Summary: | rubygem-timeout - Auto-terminate potentially long-running operations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | Bug | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2022-10-31 19:48:42 UTC
Just a quick glance, but: * Meanwhile, 0.4.0 is out, would you update? * URL seems wrong, the correct one seems https://github.com/ruby/timeout * So this rpmspec file has "BR: rubygem(rake) , bundler and so on, but actually no %check? By the way, you can just use rake for %check if it is necessary, but in this case it seems the testsuite can be executed by: $ ruby -I.:lib -rtest/lib/helper -e 'Dir.glob("test/**/test_*.rb").each {|f| require f}' (Actually you can check this by Rakefile: https://github.com/ruby/timeout/blob/413194f8d2650c6ca7b2a45b38f8c9aca53ba846/Rakefile#L6-L7 ) Note that with 0.4.0, now testsuite uses rubygem-test-unit-ruby-core (which was just approved by you!): https://github.com/ruby/timeout/commit/1c91ac24227bb927ce4b341c6184c989a741cf98 * Rakefile is something like Makefile written in ruby, and personally I don't package this into final binary rpm, but this is not a blocker. |