Spec URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-timeout/fedora-rawhide-x86_64/04999202-rubygem-timeout/rubygem-timeout.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-timeout/fedora-rawhide-x86_64/04999202-rubygem-timeout/rubygem-timeout-0.3.0-1.fc38.src.rpm Description: Timeout provides a way to auto-terminate a potentially long-running operation if it hasn't finished in a fixed amount of time. Previous versions didn't use a module for namespacing, however #timeout is provided for backwards compatibility. You should prefer Timeout.timeout instead. Fedora Account System Username: fed500 Comments: a) Dependency of https://rubygems.org/gems/net-protocol which is a dependency of https://github.com/wconrad/ftpd which would like to package. b) rdoc directory currently not packaged due to embedded fonts and javascript. Can be added later once there is a consistent policy. c) Tests currently not run because they use rake.
Just a quick glance, but: * Meanwhile, 0.4.0 is out, would you update? * URL seems wrong, the correct one seems https://github.com/ruby/timeout * So this rpmspec file has "BR: rubygem(rake) , bundler and so on, but actually no %check? By the way, you can just use rake for %check if it is necessary, but in this case it seems the testsuite can be executed by: $ ruby -I.:lib -rtest/lib/helper -e 'Dir.glob("test/**/test_*.rb").each {|f| require f}' (Actually you can check this by Rakefile: https://github.com/ruby/timeout/blob/413194f8d2650c6ca7b2a45b38f8c9aca53ba846/Rakefile#L6-L7 ) Note that with 0.4.0, now testsuite uses rubygem-test-unit-ruby-core (which was just approved by you!): https://github.com/ruby/timeout/commit/1c91ac24227bb927ce4b341c6184c989a741cf98 * Rakefile is something like Makefile written in ruby, and personally I don't package this into final binary rpm, but this is not a blocker.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
Once closing since no progress is made for a long time.