Bug 2138993
| Summary: | Review Request: python-rust-update-set - A tool to help Fedora packagers update Rust packages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2022-11-10 16:18:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michel Lind
2022-10-31 22:54:12 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=93644149 Taking this review. Couple of notes: - I'd drop the markdown backticks from the description - I think you also need to add the license with %license Made those changes, thanks! Package using the pyproject macros, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version is packaged - license matches upstream specification and is acceptable for Fedora - package complies with Python Packaging Guidelines Package APPROVED. Thanks! rust-update-set on main [?] via 🐍 v3.11.0rc1 took 7s ⬢ [fedora-toolbox:37] ❯ fedpkg request-repo python-rust-update-set 2138993 https://pagure.io/releng/fedora-scm-requests/issue/48534 rust-update-set on main [?] via 🐍 v3.11.0rc1 ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-rust-update-set f37 https://pagure.io/releng/fedora-scm-requests/issue/48535 rust-update-set on main [?] via 🐍 v3.11.0rc1 took 4s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-rust-update-set f36 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rust-update-set FEDORA-2022-cf22441180 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cf22441180 FEDORA-2022-3c0c4c9eb6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c0c4c9eb6 FEDORA-2022-3c0c4c9eb6 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3c0c4c9eb6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c0c4c9eb6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-cf22441180 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-cf22441180 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cf22441180 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2022-cf22441180 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2022-3c0c4c9eb6 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |