Bug 2138993 - Review Request: python-rust-update-set - A tool to help Fedora packagers update Rust packages
Summary: Review Request: python-rust-update-set - A tool to help Fedora packagers upda...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-31 22:54 UTC by Michel Lind
Modified: 2022-11-10 22:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-11-10 16:18:40 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-10-31 22:54:12 UTC
Spec URL: https://salimma.fedorapeople.org/python-rust-update-set.spec
SRPM URL: https://salimma.fedorapeople.org/python-rust-update-set-0.0.1-1.fc37.src.rpm

Description:
`rust-update-set` is a Fedora packager tool which tries to automate some common tasks
like:

- recursively check out all packages that need to be updated or missing deps that need to be packaged
- preserve changes in old spec file when updating spec file using rust2rpm
- check update compatibility and create packages with suffix when a transitive closure is introduced
- automate parallel COPR builds of sets of packages in dependency order
- chain-build all packages in Koji with requested side tag
- merging and chain-building all packages across release branches
- create compat crate rust-{crate}{older} when updating some packages will break other packages.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-10-31 22:58:27 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=93644149

Comment 2 Davide Cavalca 2022-11-01 01:45:53 UTC
Taking this review. Couple of notes:
- I'd drop the markdown backticks from the description
- I think you also need to add the license with %license

Comment 3 Michel Lind 2022-11-01 02:17:02 UTC
Made those changes, thanks!

Comment 4 Davide Cavalca 2022-11-01 02:18:29 UTC
Package using the pyproject macros, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version is packaged
- license matches upstream specification and is acceptable for Fedora
- package complies with Python Packaging Guidelines

Package APPROVED.

Comment 5 Michel Lind 2022-11-01 02:20:40 UTC
Thanks!

rust-update-set on  main [?] via 🐍 v3.11.0rc1 took 7s                         
⬢ [fedora-toolbox:37] ❯ fedpkg request-repo python-rust-update-set 2138993      
https://pagure.io/releng/fedora-scm-requests/issue/48534                        
                                                          
rust-update-set on  main [?] via 🐍 v3.11.0rc1 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-rust-update-set f37
https://pagure.io/releng/fedora-scm-requests/issue/48535

rust-update-set on  main [?] via 🐍 v3.11.0rc1 took 4s 
⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo python-rust-update-set f36

Comment 6 Gwyn Ciesla 2022-11-01 15:34:38 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rust-update-set

Comment 7 Fedora Update System 2022-11-01 17:41:25 UTC
FEDORA-2022-cf22441180 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cf22441180

Comment 8 Fedora Update System 2022-11-01 17:41:26 UTC
FEDORA-2022-3c0c4c9eb6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c0c4c9eb6

Comment 9 Fedora Update System 2022-11-02 13:34:35 UTC
FEDORA-2022-3c0c4c9eb6 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-3c0c4c9eb6 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3c0c4c9eb6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-11-02 15:16:04 UTC
FEDORA-2022-cf22441180 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-cf22441180 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cf22441180

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-11-10 16:18:40 UTC
FEDORA-2022-cf22441180 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-11-10 22:30:28 UTC
FEDORA-2022-3c0c4c9eb6 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.