Bug 2140708 (golang-oras)

Summary:	Review Request: golang-oras - Work with OCI registries, but for secure supply chain
Product:	[Fedora] Fedora	Reporter:	Robert-André Mauchin 🐧 <eclipseo>
Component:	Package Review	Assignee:	Davide Cavalca <davide>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	davide, matt.hickford, package-review
Target Milestone:	---	Flags:	davide: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	2172238 (view as bug list)		Environment:
Last Closed:	2023-02-21 17:11:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2140707, 2140709, 2172236, 2172237
Bug Blocks:	2138839, 2138841, 2172238

Description Robert-André Mauchin 🐧 2022-11-07 17:14:00 UTC

Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-oras.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-oras-0.15.1-1.20221105git690716b.fc37.src.rpm

Description:
Work with OCI registries, but for secure supply chain - managing content like artifacts, images, SBOM.

Fedora Account System Username: eclipseo

Comment 1 M Hickford 2022-11-13 17:16:24 UTC

"not yet a packager and the review is thus unofficial"

Is it necessary to include both BuildRequires and go_generate_buildrequires?

BuildRequires:  golang(oras.land/oras-go/v2)

%generate_buildrequires
%go_generate_buildrequires

Comment 2 Davide Cavalca 2023-01-17 05:39:46 UTC

Taking this review

Comment 3 Davide Cavalca 2023-01-17 05:55:15 UTC

This fails to build with

No matching package to install: 'golang(github.com/need-being/go-tree)'

Comment 4 Davide Cavalca 2023-01-17 06:07:19 UTC

I can confirm this does need the explicit BR on golang(oras.land/oras-go/v2) or it'll fail to build.

Comment 5 Davide Cavalca 2023-01-17 06:11:00 UTC

Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the package is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included
- package complies with Golang Packaging Guidelines

Package APPROVED.

Comment 6 Davide Cavalca 2023-02-21 17:11:08 UTC

Took this over to unblock helm

*** This bug has been marked as a duplicate of bug 2172238 ***