+++ This bug was initially created as a clone of Bug #2140708 +++

Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-oras.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-oras-0.15.1-1.20221105git690716b.fc37.src.rpm

Description:
Work with OCI registries, but for secure supply chain - managing content like artifacts, images, SBOM.

Fedora Account System Username: dcavalca

--- Additional comment from M Hickford on 2022-11-13 17:16:24 UTC ---

"not yet a packager and the review is thus unofficial"

Is it necessary to include both BuildRequires and go_generate_buildrequires?

BuildRequires:  golang(oras.land/oras-go/v2)

%generate_buildrequires
%go_generate_buildrequires

--- Additional comment from Davide Cavalca on 2023-01-17 05:39:46 UTC ---

Taking this review

--- Additional comment from Davide Cavalca on 2023-01-17 05:55:15 UTC ---

This fails to build with

No matching package to install: 'golang(github.com/need-being/go-tree)'

--- Additional comment from Davide Cavalca on 2023-01-17 06:07:19 UTC ---

I can confirm this does need the explicit BR on golang(oras.land/oras-go/v2) or it'll fail to build.

--- Additional comment from Davide Cavalca on 2023-01-17 06:11:00 UTC ---

Package was generated with go2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the package is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included
- package complies with Golang Packaging Guidelines

Package APPROVED.