Bug 2143591
| Summary: | fcgi: Adjustments for building without implicit function declarations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||
| Component: | fcgi | Assignee: | Florian Weimer <fweimer> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | ktdreyer, zonexpertconsulting | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fcgi-2.4.0-45.fc38 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-11-17 10:56:14 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2141798 | ||||||
| Attachments: |
|
||||||
|
Description
Florian Weimer
2022-11-17 10:21:13 UTC
Created attachment 1924965 [details]
fcgi-configure-exit.patch
This appears to be the most straightforward fix. It works with libstdc++.
Thanks for doing the work, but could you provide some additional background? I get the general problem behind function declarations: https://stackoverflow.com/questions/9182763/implicit-function-declarations-in-c However, what drove you to address this? I didn't see any build failure notices for this package prior to the patch. Did you just want to remove the warnings that gcc likely was giving during the build, or was there some other, specific issue this addressed? ...or is there an upcoming change to the fedora build environment, such as enforcing C99, which would cause this to fail the build? I am trying to get a better understanding, to determine whether the EPEL branches should receive this patch as well. It's related to: https://fedoraproject.org/wiki/Changes/PortingToModernC https://fedoraproject.org/wiki/Toolchain/PortingToModernC It's in preparation of a potential change in GCC 14. In a few cases (probably this one), we have to patch packages to silence the reports (which I'm still trying to get off the ground, I'll update the second wiki page once I've got details). Perfect. Thank you for explaining. Sorry, I botched my testing and missed another implicit exit declaration. Should be fixed now. |