Bug 2143591 - fcgi: Adjustments for building without implicit function declarations
Summary: fcgi: Adjustments for building without implicit function declarations
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fcgi
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2022-11-17 10:21 UTC by Florian Weimer
Modified: 2022-11-18 08:19 UTC (History)
2 users (show)

Fixed In Version: fcgi-2.4.0-45.fc38
Clone Of:
Environment:
Last Closed: 2022-11-17 10:56:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
fcgi-configure-exit.patch (1.68 KB, patch)
2022-11-17 10:55 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2022-11-17 10:21:13 UTC
The fcgi configure scripts were built with an old autoconf version which uses an implicit declaration of exit.

The fcgi upstream site appears to be down (for many years), so it has to be a downstream-only patch.

Comment 1 Florian Weimer 2022-11-17 10:55:51 UTC
Created attachment 1924965 [details]
fcgi-configure-exit.patch

This appears to be the most straightforward fix. It works with libstdc++.

Comment 2 Andrew Bauer 2022-11-17 13:07:18 UTC
Thanks for doing the work, but could you provide some additional background?

I get the general problem behind function declarations:
https://stackoverflow.com/questions/9182763/implicit-function-declarations-in-c

However, what drove you to address this? I didn't see any build failure notices for this package prior to the patch. Did you just want to remove the warnings that gcc likely was giving during the build, or was there some other, specific issue this addressed?

...or is there an upcoming change to the fedora build environment, such as enforcing C99, which would cause this to fail the build?

I am trying to get a better understanding, to determine whether the EPEL branches should receive this patch as well.

Comment 3 Florian Weimer 2022-11-17 13:12:45 UTC
It's related to:

  https://fedoraproject.org/wiki/Changes/PortingToModernC
  https://fedoraproject.org/wiki/Toolchain/PortingToModernC

It's in preparation of a potential change in GCC 14. In a few cases (probably this one), we have to patch packages to silence the reports (which I'm still trying to get off the ground, I'll update the second wiki page once I've got details).

Comment 4 Andrew Bauer 2022-11-17 13:18:13 UTC
Perfect. Thank you for explaining.

Comment 5 Florian Weimer 2022-11-18 08:19:03 UTC
Sorry, I botched my testing and missed another implicit exit declaration. Should be fixed now.


Note You need to log in before you can comment on or make changes to this bug.