Bug 2145150

Summary:	ncl: C99 port or switch language mode to C89?
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	ncl	Assignee:	Florian Weimer <fweimer>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	orion, scitech-bugs
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ncl-6.6.2-37.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-29 14:24:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2137516

Description Florian Weimer 2022-11-23 11:07:03 UTC

This bug mainly serves as a downstream tracker for the upstream response here:

  Choice of C language mode: C99 on Linux despite C99 incompatibilities
  <https://github.com/NCAR/ncl/issues/193>

Upstream explicitly uses -std=c99, so it's not clear what we should do here. For other packages with C89-only constructs, we simply switched building in C89 mode; see bug 2137516.

It doesn't help that upstream seems to be in maintenance mode. A full port to C2X seems out of the question because old-style function definitions are used throughout the code (and it is out of scope for the Fedora project anyway).

Comment 1 Ben Cotton 2023-02-07 14:59:40 UTC

This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Florian Weimer 2023-08-29 14:24:13 UTC

I have exempted this package from the general build flag changes.