Bug 2145150 - ncl: C99 port or switch language mode to C89?
Summary: ncl: C99 port or switch language mode to C89?
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ncl
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2022-11-23 11:07 UTC by Florian Weimer
Modified: 2023-08-29 14:24 UTC (History)
2 users (show)

Fixed In Version: ncl-6.6.2-37.fc40
Clone Of:
Environment:
Last Closed: 2023-08-29 14:24:13 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github NCAR ncl issues 193 0 None open Choice of C language mode: C99 on Linux despite C99 incompatibilities 2022-11-23 11:07:02 UTC

Description Florian Weimer 2022-11-23 11:07:03 UTC 
This bug mainly serves as a downstream tracker for the upstream response here:

  Choice of C language mode: C99 on Linux despite C99 incompatibilities
  <https://github.com/NCAR/ncl/issues/193>

Upstream explicitly uses -std=c99, so it's not clear what we should do here. For other packages with C89-only constructs, we simply switched building in C89 mode; see bug 2137516.

It doesn't help that upstream seems to be in maintenance mode. A full port to C2X seems out of the question because old-style function definitions are used throughout the code (and it is out of scope for the Fedora project anyway).
Comment 1 Ben Cotton 2023-02-07 14:59:40 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 2 Florian Weimer 2023-08-29 14:24:13 UTC 
I have exempted this package from the general build flag changes.
Note You need to log in before you can comment on or make changes to this bug.