Bug 2148739

Summary: xloadimage: Port to C99
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: xloadimageAssignee: Florian Weimer <fweimer>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: spotrh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: xloadimage-4.1-34.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-11-27 16:44:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 2141798    
Description Flags
xloadimage-c99.patch none

Description Florian Weimer 2022-11-27 16:16:24 UTC
Created attachment 1927849 [details]

A few changes are needed to build with compilers which do not support implicit ints and implicit function declarations. I also spotted one case where pointer clipping occurs due to the missing type declaration (which is not int in this case).

Comment 1 Florian Weimer 2022-11-27 16:18:16 UTC
I forgot to mention that I filed this bug because there doesn't seem to be an upstream project with its own bug tracker.