Bug 2148739 - xloadimage: Port to C99
Summary: xloadimage: Port to C99
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: xloadimage
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2022-11-27 16:16 UTC by Florian Weimer
Modified: 2022-11-27 16:44 UTC (History)
1 user (show)

Fixed In Version: xloadimage-4.1-34.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-27 16:44:33 UTC
Type: Bug

Attachments (Terms of Use)
xloadimage-c99.patch (3.83 KB, patch)
2022-11-27 16:16 UTC, Florian Weimer 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Gentoo 875422 0 None None None 2022-11-27 16:19:33 UTC

Description Florian Weimer 2022-11-27 16:16:24 UTC 
Created attachment 1927849 [details]
xloadimage-c99.patch

A few changes are needed to build with compilers which do not support implicit ints and implicit function declarations. I also spotted one case where pointer clipping occurs due to the missing type declaration (which is not int in this case).
Comment 1 Florian Weimer 2022-11-27 16:18:16 UTC 
I forgot to mention that I filed this bug because there doesn't seem to be an upstream project with its own bug tracker.
Note You need to log in before you can comment on or make changes to this bug.