Bug 2149230

Summary: nas: Port to C99
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: nasAssignee: Petr Pisar <ppisar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ppisar, rdieter
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://sourceforge.net/p/nas/bugs/10/
Whiteboard:
Fixed In Version: nas-1.9.5-4.fc38 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-02-08 12:43:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2137512    

Description Florian Weimer 2022-11-29 09:37:15 UTC
The package contains many implicit ints, implicit function declarations, and old-style function definitions. It does not seem to build it in C99 and later language modes.

Comment 1 Petr Pisar 2022-11-29 09:39:34 UTC
I know about it and I'm slowly working on it.

Comment 2 Florian Weimer 2022-11-29 09:49:42 UTC
(In reply to Petr Pisar from comment #1)
> I know about it and I'm slowly working on it.

I have a patch that switches to C89 mode, which will keep working for a long time (I expect). I can hold off pushing it if you want to port the sources instead.

There's a glitch because of autoreconf and the new configure script upgrading past C89, but I have worked around that.

Comment 3 Petr Pisar 2022-11-29 09:52:48 UTC
I'd prefer not switching to C89. Otherwise I won't be motivated to port the code.

Comment 4 Florian Weimer 2022-11-29 09:59:54 UTC
Sure, the task is yours.

Comment 5 Petr Pisar 2023-01-19 16:59:58 UTC
I have a patch porting the code. I will give some time to the upstream for a review. Then I will apply it to Fedora.

Comment 6 Ben Cotton 2023-02-07 15:11:28 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 7 Florian Weimer 2023-02-08 13:10:52 UTC
Thank you, results look good!