Bug 2149230 - nas: Port to C99
Summary: nas: Port to C99
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: nas
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL: https://sourceforge.net/p/nas/bugs/10/
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2022-11-29 09:37 UTC by Florian Weimer
Modified: 2023-02-08 13:10 UTC (History)
2 users (show)

Fixed In Version: nas-1.9.5-4.fc38
Clone Of:
Environment:
Last Closed: 2023-02-08 12:43:16 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2022-11-29 09:37:15 UTC 
The package contains many implicit ints, implicit function declarations, and old-style function definitions. It does not seem to build it in C99 and later language modes.
Comment 1 Petr Pisar 2022-11-29 09:39:34 UTC 
I know about it and I'm slowly working on it.
Comment 2 Florian Weimer 2022-11-29 09:49:42 UTC 
(In reply to Petr Pisar from comment #1)
> I know about it and I'm slowly working on it.

I have a patch that switches to C89 mode, which will keep working for a long time (I expect). I can hold off pushing it if you want to port the sources instead.

There's a glitch because of autoreconf and the new configure script upgrading past C89, but I have worked around that.
Comment 3 Petr Pisar 2022-11-29 09:52:48 UTC 
I'd prefer not switching to C89. Otherwise I won't be motivated to port the code.
Comment 4 Florian Weimer 2022-11-29 09:59:54 UTC 
Sure, the task is yours.
Comment 5 Petr Pisar 2023-01-19 16:59:58 UTC 
I have a patch porting the code. I will give some time to the upstream for a review. Then I will apply it to Fedora.
Comment 6 Ben Cotton 2023-02-07 15:11:28 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.
Comment 7 Florian Weimer 2023-02-08 13:10:52 UTC 
Thank you, results look good!
Note You need to log in before you can comment on or make changes to this bug.