Bug 2149698

Updated to version 0.14.9, new SRPM URL:

Spec URL: https://jonny.fedorapeople.org/sile.spec
SRPM URL: https://jonny.fedorapeople.org/sile-0.14.9-1.fc36.src.rpm

Updated to version 0.14.10, new SRPM URL:

Spec URL: https://jonny.fedorapeople.org/sile.spec
SRPM URL: https://jonny.fedorapeople.org/sile-0.14.10-1.fc38.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6300310
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2149698-sile/fedora-rawhide-x86_64/06300310-sile/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

 - Please use autochangelog/autorelease

 - Requires: libtexpdf = %{version}

-> should include arch:


Requires:  libtexpdf%{?_isa} = %{version}-%{release}

 - Why is this bundled? Was it modified by the project?

Provides: bundled(lua-lunamark)

 - Same question about libtexpdf

%package -n libtexpdf
Summary: bundled with SILE

It seems that it is straight taken from another repo. Why don't you package it separately?

Also that Summary is a no go. We don't care about the fact that it is bundled in the summary, the user needs to know what this package do.

I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems there is no release tarball anymore, but you can still grab an archive from a commit.

I saw this too https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-1301767989 but there is a cmake script now and you only need zlib and libpng.

Please consider it.

(In reply to Robert-André Mauchin 🐧 from comment #4)
>  - Please use autochangelog/autorelease

I will update the spec.


>  - Requires: libtexpdf = %{version}
> 
> -> should include arch:

Yes, arch should also be included.

> 
> 
> Requires:  libtexpdf%{?_isa} = %{version}-%{release}
> 
>  - Why is this bundled? Was it modified by the project?

I think it is extracted from Tex Live into its own git repo by the SILE team. This git repo have no releases.
This git repo have only been integrated with SILE as a git submodule.


> 
> Provides: bundled(lua-lunamark)
> 
>  - Same question about libtexpdf

Seems like they are working on unbundling lunamark:
https://github.com/sile-typesetter/sile/issues/669

> 
> %package -n libtexpdf
> Summary: bundled with SILE
> 
> It seems that it is straight taken from another repo. Why don't you package
> it separately?
> 
> Also that Summary is a no go. We don't care about the fact that it is
> bundled in the summary, the user needs to know what this package do.

That is a good point.

> 
> I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems
> there is no release tarball anymore, but you can still grab an archive from
> a commit.
> 
> I saw this too
> https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-
> 1301767989 but there is a cmake script now and you only need zlib and libpng.
> 
> Please consider it.

I will try to package it directly from the commit that is used by SILE.