Bug 2149698 - Review Request: sile - The SILE Typesetter [NEEDINFO]
Summary: Review Request: sile - The SILE Typesetter
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://sile-typesetter.org/
Whiteboard:
Depends On: 2143028 2142399 2142653 2142671 2142786 2142798 2143020 2143050 2143056 2143351 2143382 2143391 2149626 2149686
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-30 16:07 UTC by Jonny Heggheim
Modified: 2023-08-17 13:22 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
zebob.m: needinfo? (hegjon)


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github sile-typesetter sile issues 669 0 None open Extricate Lunamark from source tree 2023-08-17 13:22:08 UTC

Description Jonny Heggheim 2022-11-30 16:07:51 UTC
Spec URL: https://jonny.fedorapeople.org/sile.spec
SRPM URL: https://jonny.fedorapeople.org/sile-0.14.5-1.fc36.src.rpm

Description:
SILE is a typesetting system; its job is to produce beautiful printed documents.
Conceptually, SILE is similar to TeX—from which it borrows some concepts and
even syntax and algorithms—but the similarities end there.
Rather than being a derivative of the TeX family SILE is a new typesetting and
layout engine written from the ground up using modern technologies and borrowing
some ideas from graphical systems such as InDesign.

Fedora Account System Username: jonny

Comment 1 Jonny Heggheim 2023-06-12 21:51:02 UTC
Updated to version 0.14.9, new SRPM URL:

Spec URL: https://jonny.fedorapeople.org/sile.spec
SRPM URL: https://jonny.fedorapeople.org/sile-0.14.9-1.fc36.src.rpm

Comment 2 Jonny Heggheim 2023-08-15 21:27:29 UTC
Updated to version 0.14.10, new SRPM URL:

Spec URL: https://jonny.fedorapeople.org/sile.spec
SRPM URL: https://jonny.fedorapeople.org/sile-0.14.10-1.fc38.src.rpm

Comment 3 Fedora Review Service 2023-08-15 21:30:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6300310
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2149698-sile/fedora-rawhide-x86_64/06300310-sile/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Robert-André Mauchin 🐧 2023-08-16 20:57:14 UTC
 - Please use autochangelog/autorelease

 - Requires: libtexpdf = %{version}

-> should include arch:


Requires:  libtexpdf%{?_isa} = %{version}-%{release}

 - Why is this bundled? Was it modified by the project?

Provides: bundled(lua-lunamark)

 - Same question about libtexpdf

%package -n libtexpdf
Summary: bundled with SILE

It seems that it is straight taken from another repo. Why don't you package it separately?

Also that Summary is a no go. We don't care about the fact that it is bundled in the summary, the user needs to know what this package do.

I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems there is no release tarball anymore, but you can still grab an archive from a commit.

I saw this too https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-1301767989 but there is a cmake script now and you only need zlib and libpng.

Please consider it.

Comment 5 Jonny Heggheim 2023-08-17 13:22:08 UTC
(In reply to Robert-André Mauchin 🐧 from comment #4)
>  - Please use autochangelog/autorelease

I will update the spec.


>  - Requires: libtexpdf = %{version}
> 
> -> should include arch:

Yes, arch should also be included.

> 
> 
> Requires:  libtexpdf%{?_isa} = %{version}-%{release}
> 
>  - Why is this bundled? Was it modified by the project?

I think it is extracted from Tex Live into its own git repo by the SILE team. This git repo have no releases.
This git repo have only been integrated with SILE as a git submodule.


> 
> Provides: bundled(lua-lunamark)
> 
>  - Same question about libtexpdf

Seems like they are working on unbundling lunamark:
https://github.com/sile-typesetter/sile/issues/669

> 
> %package -n libtexpdf
> Summary: bundled with SILE
> 
> It seems that it is straight taken from another repo. Why don't you package
> it separately?
> 
> Also that Summary is a no go. We don't care about the fact that it is
> bundled in the summary, the user needs to know what this package do.

That is a good point.

> 
> I saw https://github.com/sile-typesetter/libtexpdf/issues/25 and it seems
> there is no release tarball anymore, but you can still grab an archive from
> a commit.
> 
> I saw this too
> https://github.com/sile-typesetter/libtexpdf/issues/3#issuecomment-
> 1301767989 but there is a cmake script now and you only need zlib and libpng.
> 
> Please consider it.

I will try to package it directly from the commit that is used by SILE.


Note You need to log in before you can comment on or make changes to this bug.