Bug 2151473
| Summary: | giac: C99 compatibility improvements | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> | ||||||
| Component: | giac | Assignee: | Florian Weimer <fweimer> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | trpost | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | giac-1.9.0.29-2.fc38 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2022-12-22 10:14:18 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2141798 | ||||||||
| Attachments: |
|
||||||||
Regarding the fesetround issue, there is a stray fenv.h file (with incompatible definitions) in the source tree. Created attachment 1930761 [details] Remove <fenv.h> override This patch is required to remove the <fenv.h> override. The build now succeeds. I think I'm going to push this in the light of the breakage reported in bug 2150422. It seems a reasonable cleanup. Upstream forum account has still not been activated. Looks like I won't get upstream forum access, so the patch remains downstream-only. |
Created attachment 1930744 [details] giac-alloca-c99.patch It appears that in micropython, mpconfigport.h is responsible for including <alloca.h> or equivalent. In the bundled copy, micropython-1.12/xcas/mpconfigport.h has the include directive commented out. This results in an implicit declaration. There is another issue in the bundled quickjs code: It seems that <fenv.h> is not included for fesetround (still need to investigate that). I'll try to report these issues on the upstream forum.