Bug 2151473 - giac: C99 compatibility improvements
Summary: giac: C99 compatibility improvements
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: giac
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2022-12-07 09:51 UTC by Florian Weimer
Modified: 2022-12-22 10:14 UTC (History)
1 user (show)

Fixed In Version: giac-1.9.0.29-2.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-22 10:14:18 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
giac-alloca-c99.patch (391 bytes, patch)
2022-12-07 09:51 UTC, Florian Weimer
no flags Details | Diff
Remove <fenv.h> override (1.01 KB, patch)
2022-12-07 10:28 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2022-12-07 09:51:19 UTC
Created attachment 1930744 [details]
giac-alloca-c99.patch

It appears that in micropython, mpconfigport.h is responsible for including <alloca.h> or equivalent. In the bundled copy, micropython-1.12/xcas/mpconfigport.h has the include directive commented out. This results in an implicit declaration.

There is another issue in the bundled quickjs code: It seems that <fenv.h> is not included for fesetround (still need to investigate that).

I'll try to report these issues on the upstream forum.

Comment 1 Florian Weimer 2022-12-07 09:54:17 UTC
Regarding the fesetround issue, there is a stray fenv.h file (with incompatible definitions) in the source tree.

Comment 2 Florian Weimer 2022-12-07 10:28:03 UTC
Created attachment 1930761 [details]
Remove <fenv.h> override

This patch is required to remove the <fenv.h> override. The build now succeeds. I think I'm going to push this in the light of the breakage reported in bug 2150422. It seems a reasonable cleanup.

Upstream forum account has still not been activated.

Comment 3 Florian Weimer 2022-12-22 10:14:18 UTC
Looks like I won't get upstream forum access, so the patch remains downstream-only.


Note You need to log in before you can comment on or make changes to this bug.