Bug 2153791
| Summary: | postgresql-pgpool-II: C99 compatibility issue | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Florian Weimer <fweimer> |
| Component: | postgresql-pgpool-II | Assignee: | Filip Januš <fjanus> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | devrim, fjanus, hhorak, jmlich83, osloup, praiskup |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | postgresql-pgpool-II-4.4.2-1.fc38 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-02-05 10:53:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2137512 | ||
Upstream posting: [pgpool-hackers: 4240] Proper declaration for SplitIdentifierString <https://www.pgpool.net/pipermail/pgpool-hackers/2022-December/004241.html> Fixed via upstream import. Thanks. |
The build logs show an implicit function declaration: pgpool-regclass.c: In function 'MystringToQualifiedNameList': pgpool-regclass.c:123:7: warning: implicit declaration of function 'SplitIdentifierString' [-Wimplicit-function-declaration] if (!SplitIdentifierString(rawname, '.', &namelist)) ^~~~~~~~~~~~~~~~~~~~~ This is not a Fedora-specific issue, the upstream builders show it as well. This is a C99 compatibility problem that needs to be addressed to avoid future build failures. I tried to with a small patch, but the header file that declares SplitIdentifierString (src/include/utils/pool_relcache.h) is not immediate compatible with the src/utils/pool_relcache.c file, so this may need some refactoring. I'll try to report this issue upstream as well.