Bug 2153791 - postgresql-pgpool-II: C99 compatibility issue
Summary: postgresql-pgpool-II: C99 compatibility issue
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: postgresql-pgpool-II
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Filip Januš
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2022-12-15 13:45 UTC by Florian Weimer
Modified: 2023-02-05 10:53 UTC (History)
6 users (show)

Fixed In Version: postgresql-pgpool-II-4.4.2-1.fc38
Clone Of:
Environment:
Last Closed: 2023-02-05 10:53:30 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Florian Weimer 2022-12-15 13:45:21 UTC 
The build logs show an implicit function declaration:

pgpool-regclass.c: In function 'MystringToQualifiedNameList':
pgpool-regclass.c:123:7: warning: implicit declaration of function 'SplitIdentifierString' [-Wimplicit-function-declaration]
  if (!SplitIdentifierString(rawname, '.', &namelist))
       ^~~~~~~~~~~~~~~~~~~~~

This is not a Fedora-specific issue, the upstream builders show it as well.

This is a C99 compatibility problem that needs to be addressed to avoid future build failures. I tried to with a small patch, but the header file that declares SplitIdentifierString (src/include/utils/pool_relcache.h) is not immediate compatible with the src/utils/pool_relcache.c file, so this may need some refactoring.

I'll try to report this issue upstream as well.
Comment 1 Florian Weimer 2022-12-15 18:00:49 UTC 
Upstream posting:

[pgpool-hackers: 4240] Proper declaration for SplitIdentifierString
<https://www.pgpool.net/pipermail/pgpool-hackers/2022-December/004241.html>
Comment 2 Florian Weimer 2023-02-05 10:53:30 UTC 
Fixed via upstream import. Thanks.
Note You need to log in before you can comment on or make changes to this bug.