Bug 215452
| Summary: | Replacing -D<DEFINE> with AC_DEFINE to reduce the compile command line length | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Noriko Hosoi <nhosoi> | ||||||||
| Component: | Unknown | Assignee: | Noriko Hosoi <nhosoi> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 1.0.2 | CC: | nkinder, rmeggins | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-12-07 16:38:24 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 152373, 240316, 427409 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 141127 [details]
cvs diff configure.ac
The changes look good. Here are my comments on your questions: 1. The descriptions look fine. 2. If they are not being used, I'd rather just get rid of them. 3. I think we have too many OS macros as it is, so I'd rather not add more. Created attachment 141206 [details]
cvs diff configure.ac
Thank you for reviewing the changes, Rich and Nathan.
Following the comments by Nathan, I removed the unused "_PR_NTHREAD" macro and
tested on HP-UX.
Created attachment 141207 [details]
cvs commit (configure.ac configure config.h.in)
Checked in into HEAD.
Checked source tree: $ pwd /share/dev4/ds/ds80/builds/20071129.1/earthquake_rhel4/ldapserver There is no platform_defs which used to be used to pass macro with -D to make. $ egrep platform_defs configure.ac $ Also config.h.in is in the tree. I.e., verified. |
Description of problem: In the review of [214533], Nathan suggested to add the platform dependent define macros to config.h and eliminate the lengthy "-D<define>" from the compile command line. I also think that's a good idea. So, here's the proposed diff... Here are some issues I'd like to have your comments. 1. autoheader does not like AC_DEFINE([XP_UNIX], [1]) nor AC_DEFINE([XP_UNIX], [1], []) It looks it requires some description. (actually, it makes sense since the description appears as a comment for the macro) Are these descriptions appropriate? 2. There are some macros which do not appear in the source codes (DS as well as the components). There are two kinds. a. CPU_ia64 or HPUX11_##: they'd be useful if such platform dependency needs to be supported. b. _PR_NTHREAD: do we want to keep this? 3. This is minor, but only Linux does not have "CPU_xxx" and "OS_linux" macros. Do we want to add them?