Bug 215452 - Replacing -D<DEFINE> with AC_DEFINE to reduce the compile command line length
Summary: Replacing -D<DEFINE> with AC_DEFINE to reduce the compile command line length
Alias: None
Product: 389
Classification: Retired
Component: Unknown   
(Show other bugs)
Version: 1.0.2
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Noriko Hosoi
QA Contact: Viktor Ashirov
Depends On:
Blocks: 152373 240316 FDS1.1.0
TreeView+ depends on / blocked
Reported: 2006-11-14 02:05 UTC by Noriko Hosoi
Modified: 2015-12-07 16:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2015-12-07 16:38:24 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
cvs diff configure.ac (3.40 KB, patch)
2006-11-14 02:05 UTC, Noriko Hosoi
no flags Details | Diff
cvs diff configure.ac (3.30 KB, patch)
2006-11-15 02:05 UTC, Noriko Hosoi
no flags Details | Diff
cvs commit (configure.ac configure config.h.in) (704 bytes, text/plain)
2006-11-15 02:08 UTC, Noriko Hosoi
no flags Details

Description Noriko Hosoi 2006-11-14 02:05:09 UTC
Description of problem:
In the review of [214533], Nathan suggested to add the platform dependent define
macros to config.h and eliminate the lengthy "-D<define>" from the compile
command line.  I also think that's a good idea.

So, here's the proposed diff...

Here are some issues I'd like to have your comments.
1. autoheader does not like 
   AC_DEFINE([XP_UNIX], [1]) nor AC_DEFINE([XP_UNIX], [1], [])
   It looks it requires some description.
   (actually, it makes sense since the description appears as a comment for
    the macro)
   Are these descriptions appropriate?
2. There are some macros which do not appear in the source codes (DS as well
   as the components).
   There are two kinds.
   a. CPU_ia64 or HPUX11_##: they'd be useful if such platform dependency
      needs to be supported.
   b. _PR_NTHREAD: do we want to keep this?
3. This is minor, but only Linux does not have "CPU_xxx" and "OS_linux" macros.
   Do we want to add them?

Comment 1 Noriko Hosoi 2006-11-14 02:05:09 UTC
Created attachment 141127 [details]
cvs diff configure.ac

Comment 2 Nathan Kinder 2006-11-14 16:09:27 UTC
The changes look good.  Here are my comments on your questions:

1. The descriptions look fine.
2. If they are not being used, I'd rather just get rid of them.
3. I think we have too many OS macros as it is, so I'd rather not add more.

Comment 3 Noriko Hosoi 2006-11-15 02:05:28 UTC
Created attachment 141206 [details]
cvs diff configure.ac

Thank you for reviewing the changes, Rich and Nathan.

Following the comments by Nathan, I removed the unused "_PR_NTHREAD" macro and
tested on HP-UX.

Comment 4 Noriko Hosoi 2006-11-15 02:08:38 UTC
Created attachment 141207 [details]
cvs commit (configure.ac configure config.h.in)

Checked in into HEAD.

Comment 5 Noriko Hosoi 2007-11-29 23:04:49 UTC
Checked source tree:
$ pwd

There is no platform_defs which used to be used to pass macro with -D to make.
$ egrep platform_defs configure.ac

Also config.h.in is in the tree.

I.e., verified.

Note You need to log in before you can comment on or make changes to this bug.