Bug 2154854

Summary:	libftdi fails to build with Python 3.12: ModuleNotFoundError: No module named 'distutils'
Product:	[Fedora] Fedora	Reporter:	Tomáš Hrnčiar <thrnciar>
Component:	libftdi	Assignee:	Dan Horák <dan>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dan, hobbes1069, lucilanga, mhroncok, redhat-bugzilla, thrnciar
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libftdi-1.5-7.fc38	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-03 17:24:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2135404

Description Tomáš Hrnčiar 2022-12-19 12:16:47 UTC

libftdi fails to build with Python 3.12.0a3.

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'distutils'

Remove the distutils package. It was deprecated in Python 3.10 by PEP 632 “Deprecate distutils module”. For projects still using distutils and cannot be updated to something else, the setuptools project can be installed: it still provides distutils. (Contributed by Victor Stinner in gh-92584.)

If your package is listed in [0], you may workaround this issue by BuildRequiring python-setuptools, note that adding such BuildRequires might however hide some transitive dependency problem, if the distutils import comes from a dependency.
Cooperation with upstream is recommended. Additional context [1].

[0] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/message/6BHNAWHE7M5VY3YQVJLOYHLY4M7KIFFN/

[1] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/N6ITYHLRWIDNYNXGPYG2ZHF3ZLQWZN7L/

https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05129090-libftdi/

For all our attempts to build libftdi with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/libftdi/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Dan Horák 2022-12-19 12:25:57 UTC

distutils is used only for find the library/module path, the following fix should work around it, but I am open to suggestions

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
index 5b6f420..d458840 100644
--- a/python/CMakeLists.txt
+++ b/python/CMakeLists.txt
@@ -42,7 +42,7 @@ endif ()
 
 set_target_properties ( ${SWIG_MODULE_ftdi1_REAL_NAME} PROPERTIES NO_SONAME ON )
 
-execute_process ( COMMAND ${PYTHON_EXECUTABLE} -c "from distutils import sysconfig; print( sysconfig.get_python_lib( plat_specific=True, prefix='${CMAKE_INSTALL_PREFIX}' ) )"
+execute_process ( COMMAND ${PYTHON_EXECUTABLE} -c "import sysconfig; print( sysconfig.get_path('stdlib') + '/site-packages' )"
                   OUTPUT_VARIABLE _ABS_PYTHON_MODULE_PATH
                   OUTPUT_STRIP_TRAILING_WHITESPACE )

Comment 2 Miro Hrončok 2022-12-19 13:17:28 UTC

I'd replace:

    sysconfig.get_path('stdlib') + '/site-packages'

with:

    sysconfig.get_path('platlib')

And if you want to keep the explicit prefix:

    sysconfig.get_path('platlib', vars={'platbase': '${CMAKE_INSTALL_PREFIX}'})

Comment 3 Dan Horák 2022-12-19 15:34:38 UTC

(In reply to Miro Hrončok from comment #2)
> I'd replace:
> 
>     sysconfig.get_path('stdlib') + '/site-packages'
> 
> with:
> 
>     sysconfig.get_path('platlib')

the problem is, at least on F-36 on ppc64le, that it returns /usr/local/lib64/python3.10/site-packages, not sure it is right (/usr/local vs /usr)
 
> And if you want to keep the explicit prefix:
> 
>     sysconfig.get_path('platlib', vars={'platbase':
> '${CMAKE_INSTALL_PREFIX}'})

this should override the default /usr/local, I will give it a try

Comment 4 Miro Hrončok 2022-12-19 15:44:53 UTC

> the problem is, at least on F-36 on ppc64le, that it returns /usr/local/lib64/python3.10/site-packages, not sure it is right (/usr/local vs /usr)

It should not do so if $RPM_BUILD_ROOT is set.

Comment 5 Dan Horák 2022-12-19 15:47:45 UTC

(In reply to Miro Hrončok from comment #4)
> > the problem is, at least on F-36 on ppc64le, that it returns /usr/local/lib64/python3.10/site-packages, not sure it is right (/usr/local vs /usr)
> 
> It should not do so if $RPM_BUILD_ROOT is set.

ah, I have tried that locally, not in a build, makes sense then :-)

Comment 6 Fedora Update System 2023-02-03 17:21:12 UTC

FEDORA-2023-ad81e3a1c0 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ad81e3a1c0

Comment 7 Fedora Update System 2023-02-03 17:24:56 UTC

FEDORA-2023-ad81e3a1c0 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.