Bug 2155013

Summary: hivex fails to build with Python 3.12: ModuleNotFoundError: No module named 'distutils'
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: hivexAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, rjones, thrnciar
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hivex-1.3.21-12.fc38 hivex-1.3.23-1.fc38 hivex-1.3.23-1.fc37 hivex-1.3.23-1.fc36 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-01-18 13:57:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2135404    

Description Tomáš Hrnčiar 2022-12-19 18:32:02 UTC
hivex fails to build with Python 3.12.0a3.

checking for Python include path... Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'distutils'

Remove the distutils package. It was deprecated in Python 3.10 by PEP 632 “Deprecate distutils module”. For projects still using distutils and cannot be updated to something else, the setuptools project can be installed: it still provides distutils. (Contributed by Victor Stinner in gh-92584.)

If your package is listed in [0], you may workaround this issue by BuildRequiring python-setuptools, note that adding such BuildRequires might however hide some transitive dependency problem, if the distutils import comes from a dependency.
Cooperation with upstream is recommended. Additional context [1].

[0] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/message/6BHNAWHE7M5VY3YQVJLOYHLY4M7KIFFN/

[1] https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/N6ITYHLRWIDNYNXGPYG2ZHF3ZLQWZN7L/

https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05128903-hivex/

For all our attempts to build hivex with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/hivex/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Richard W.M. Jones 2023-01-03 13:56:50 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=95738857

Comment 2 Richard W.M. Jones 2023-01-03 14:03:57 UTC
https://koji.fedoraproject.org/koji/taskinfo?taskID=95738983

Comment 3 Fedora Update System 2023-01-03 14:12:24 UTC
FEDORA-2023-19fed252af has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-19fed252af

Comment 4 Fedora Update System 2023-01-03 14:13:31 UTC
FEDORA-2023-19fed252af has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 5 Tomáš Hrnčiar 2023-01-18 11:26:19 UTC
There is one more usage of distutils in configure.ac.

358             PYTHON_BLDLIBRARY=`$PYTHON -c "import distutils.sysconfig; \
359                                            print (distutils.sysconfig.get_config_var('BLDLIBRARY'))"`

Because of this, HAVE_PYCAPSULE_NEW is undefined and the package fails with:

Traceback (most recent call last):
  File "/builddir/build/BUILD/hivex-1.3.21/python/./t/010-import.py", line 18, in <module>
    import hivex
  File "/builddir/build/BUILD/hivex-1.3.21/python/hivex/__init__.py", line 37, in <module>
    import libhivexmod
ImportError: /builddir/build/BUILD/hivex-1.3.21/python/.libs/libhivexmod.cpython-312-x86_64-linux-gnu.so: undefined symbol: PyCObject_FromVoidPtrAndDesc

Comment 6 Richard W.M. Jones 2023-01-18 11:50:20 UTC
Note that the upstream sources are correct:
https://github.com/libguestfs/hivex/blob/master/configure.ac

However what is happening is that my backport of the upstream
fix doesn't cover earlier changes to configure.ac which happened
since the last upstream release (1.3.21).

I think I'll just do an upstream release and drop the need for
downstream patching.

Comment 7 Fedora Update System 2023-01-18 13:55:32 UTC
FEDORA-2023-406cac8888 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-406cac8888

Comment 8 Fedora Update System 2023-01-18 13:57:52 UTC
FEDORA-2023-406cac8888 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-01-18 14:06:22 UTC
FEDORA-2023-9e3b773c50 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9e3b773c50

Comment 10 Fedora Update System 2023-01-18 14:06:39 UTC
FEDORA-2023-78272ecc63 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-78272ecc63

Comment 11 Fedora Update System 2023-01-19 09:28:48 UTC
FEDORA-2023-78272ecc63 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-78272ecc63`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-78272ecc63

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-01-19 23:59:14 UTC
FEDORA-2023-9e3b773c50 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9e3b773c50`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9e3b773c50

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-02-01 02:39:15 UTC
FEDORA-2023-9e3b773c50 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-02-03 01:39:08 UTC
FEDORA-2023-78272ecc63 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.