Bug 2155432

Summary: python-managesieve fails to build with Python 3.12: AttributeError: module 'ssl' has no attribute 'wrap_socket'
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-managesieveAssignee: Sandro <gui1ty>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mhroncok, steve.traylen, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-02 22:18:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2135404    

Description Tomáš Hrnčiar 2022-12-21 09:02:50 UTC
python-managesieve fails to build with Python 3.12.0a3.


==================================== ERRORS ====================================
__________________ ERROR collecting test/test_managesieve.py ___________________
test/test_managesieve.py:14: in <module>
    import managesieve
managesieve.py:24: in <module>
    ssl_wrap_socket = ssl.wrap_socket
E   AttributeError: module 'ssl' has no attribute 'wrap_socket'
______________________ ERROR collecting test/test_res.py _______________________
test/test_res.py:12: in <module>
    from managesieve import Oknobye
managesieve.py:24: in <module>
    ssl_wrap_socket = ssl.wrap_socket
E   AttributeError: module 'ssl' has no attribute 'wrap_socket'
=============================== warnings summary ===============================
managesieve.py:166
  /builddir/build/BUILD/managesieve-0.6/managesieve.py:166: SyntaxWarning: invalid escape sequence '\D'
    """

managesieve.py:550
  /builddir/build/BUILD/managesieve-0.6/managesieve.py:550: SyntaxWarning: 'str' object is not callable; perhaps you missed a comma?
    self.error("Unexpected result from LISTSCRIPTS: %r" (dat,))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR test/test_managesieve.py - AttributeError: module 'ssl' has no attribut...
ERROR test/test_res.py - AttributeError: module 'ssl' has no attribute 'wrap_...
!!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!!

Remove the ssl.wrap_socket() function, deprecated in Python 3.7: instead, create a ssl.SSLContext object and call its ssl.SSLContext.wrap_socket method. Any package that still uses ssl.wrap_socket() is broken and insecure. The function neither sends a SNI TLS extension nor validates server hostname. Code is subject to CWE-295: Improper Certificate Validation. (Contributed by Victor Stinner in gh-94199.)

https://github.com/python/cpython/issues/94199
https://docs.python.org/3.12/whatsnew/3.12.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.12/fedora-rawhide-x86_64/05129159-python-managesieve/

For all our attempts to build python-managesieve with Python 3.12, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/package/python-managesieve/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.12:
https://copr.fedorainfracloud.org/coprs/g/python/python3.12/

Let us know here if you have any questions.

Python 3.12 is planned to be included in Fedora 39. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.12.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2023-02-07 15:03:44 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 2 Sandro 2023-07-02 22:18:18 UTC
Fixed in rawhide once f39-python side tag is merged. Also fixed on stable branches (currently in testing).