Bug 2155628
| Summary: | Review Request: rust-tracing_chromium - Chromium tracing implementation for tracing_facade | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, package-review |
| Target Milestone: | --- | Flags: | davide:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-01-04 01:24:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2155624, 2155626 | ||
| Bug Blocks: | 2155631, 2155638 | ||
|
Description
Michel Lind
2022-12-21 16:39:26 UTC
This package doesn't include a license file. It's under 0BSD, which doesn't strictly require it, but nonetheless I'd recommend adding one and working with upstream to get that fixed. License text added, and PR filed: https://github.com/jmgao/tracing/pull/4 Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. Thanks! fedora/pkgs-sig-rust/pore took 8s ⬢ [fedora-toolbox:37] ❯ set -gx C tracing_chromium fedora/pkgs-sig-rust/pore ⬢ [fedora-toolbox:37] ❯ set -gx B 2155628 fedora/pkgs-sig-rust/pore ⬢ [fedora-toolbox:37] ❯ fedpkg request-repo rust-$C $B https://pagure.io/releng/fedora-scm-requests/issue/49982 fedora/pkgs-sig-rust/pore took 6s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C --all-releases https://pagure.io/releng/fedora-scm-requests/issue/49983 https://pagure.io/releng/fedora-scm-requests/issue/49984 fedora/pkgs-sig-rust/pore took 4s ⬢ [fedora-toolbox:37] ❯ fedpkg request-branch --repo rust-$C epel9 https://pagure.io/releng/fedora-scm-requests/issue/49985 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tracing_chromium FEDORA-EPEL-2023-ae11e26767 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767 FEDORA-2023-815ee95850 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-815ee95850 FEDORA-2023-74ed908696 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-74ed908696 FEDORA-2023-74ed908696 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-815ee95850 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-ae11e26767 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2023-ae11e26767 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |